Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/actions_secret: fix resource state when removed outside of terraform #482

Merged
merged 2 commits into from
Jun 9, 2020
Merged

resource/actions_secret: fix resource state when removed outside of terraform #482

merged 2 commits into from
Jun 9, 2020

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Jun 2, 2020

Closes #481

Changes include:

  • add logic in the resource's Read method to update the state if removed externally (e.g. in Github)
  • add a disappears acctest and refactor basic test to not re-use resources and allow for tests to run in parallel

Output of acceptance tests:

--- PASS: TestAccGithubActionsSecret_disappears (10.41s)
--- PASS: TestAccGithubActionsSecret_basic (15.74s)

@ghost ghost added the size/M label Jun 2, 2020
@anGie44 anGie44 added acceptance-test/TestAccGithubActionsSecret Type: Bug Something isn't working as documented and removed Type: Bug Something isn't working as documented labels Jun 2, 2020
@jcudit jcudit modified the milestones: v2.9.0, v2.10.0, v2.8.1 Jun 3, 2020
@jcudit jcudit merged commit f0bab3d into master Jun 9, 2020
@anGie44 anGie44 deleted the ap_actions_secret_disappears branch June 18, 2020 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
v2.8.1
Development

Successfully merging this pull request may close these issues.

Error: GET https://api.github.com/repos/org/project/actions/secrets/xxxx: 404 Not Found []
2 participants
@anGie44 @jcudit