Add import function for github_actions_organization_secret resource #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Import organization secrets along with selected repository IDs list if visibility is selected * Ignore change for plaintext_value because it won't be fetched from Github API
xun-guo-anzx
force-pushed
the
actions-org-secret-import
branch
from
ce31ea6 to
6bf374c
Compare
jcudit
reviewed
Apr 6, 2021
There was a problem hiding this comment.
Thanks for the contribution! A couple of things:
- Can you cherry-pick 0d5bf21 to pull in tests and docs for this?
- I think 👇🏾 is OK to document and defer until we see friction reported by the community.
One defect of this implementation is it won't fetch value for
plaintext_valuefor the secret to the state file. So would recommend using this along with resources ignoring changes forplaintext_value.
|
Thanks @jcudit for update and recommendation. I've updated the branch with cherry-picked commit. |
jcudit
approved these changes
Apr 17, 2021
kfcampbell
pushed a commit
to kfcampbell/terraform-provider-github
that referenced
this pull request
Jul 26, 2022
…ntegrations#745) * Add import function for github_actions_organization_secret resource * Import organization secrets along with selected repository IDs list if visibility is selected * Ignore change for plaintext_value because it won't be fetched from Github API * add test / docs for importing `github_actions_organization_secret` Co-authored-by: Jeremy Udit <jcudit@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Cases
Importer function will be useful when migrating existing Github organisational secrets to Terraform resources. This will allow importing existing organisation secrets into Terraform state along with it's visibility status and list of repositories when visibility is
selected.One defect of this implementation is it won't fetch value for
plaintext_valuefor the secret to the state file. So would recommend using this along with resources ignoring changes forplaintext_value.Changes include:
selected