Add restrict_dismissals on github_branch_protection resource
#839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcudit
approved these changes
Jul 26, 2021
kfcampbell
pushed a commit
to kfcampbell/terraform-provider-github
that referenced
this pull request
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #838
Approach
Added a new argument
restrict_dismissalstogithub_branch_protectionresource to allowRestrict who can dismiss pull request reviewsto be checked by Terraform even whendismissal_restrictionsis empty.restrict_dismissalsis ignored whendismissal_restrictionsis not empty, similar tosource_branchandsource_shafrom https://registry.terraform.io/providers/integrations/github/latest/docs/resources/branch andprivateandvisibilityfrom https://registry.terraform.io/providers/integrations/github/latest/docs/resources/repository.I have tested this functionality locally on a private registry.