New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework how we handle the file paths #1243

Closed

clangenb opened this issue Mar 28, 2023 · 1 comment

Contributor

clangenb commented Mar 28, 2023

The current way how files are referenced is terrible. I think substrate has a nice way of handling that. See how they use the BasePath in the codebase: https://github.com/paritytech/substrate/blob/dec0369a35893c2be432e74358c4c7039e1e57be/client/service/src/config.rs#L280

However, our case is a bit more complex, we need to configure:

path of things that our worker stores. This base path should be configurable with a CLI.
We probably still want to assume that the service and the enclave binary (build outputs are in the same directory).
DCAP doesn't need the spid.txt and the key.txt anymore, so we can neglect this one.

The text was updated successfully, but these errors were encountered:

Contributor Author

clangenb commented Jun 7, 2023

Will close this as we have reworked that quite a lot already in the course of #1292

clangenb closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment