Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shut down worker service gracefully whenever any parentchain dispatches System.CodeUpdated event #1633

Closed
brenzi opened this issue Nov 5, 2024 · 1 comment · Fixed by #1634
Assignees

Comments

@brenzi
Copy link
Collaborator

brenzi commented Nov 5, 2024

As a simple solution to the change in metadata and runtime spec_version and transaction_version, we could just shut down the service gracefully and have it restart automatically.

caveats:

  • TOP pool will be lost. Not dramatic, as no user got a confirmation. submission will just time out or abort
  • When the System.CodeUpdated event is dispatched, it is already too late to send extrinsics with the wrong AdditionalParams. If we want to prevent this transient risk, we need to shut down already at System.UpgradeAuthorized and await the upgrade
    • one solution could be to reject TOPs which cause extrinsiscs on parentchains to be rejected after UpgradeAuthorized. this would minimize downtime while maintaining consistency
@clangenb
Copy link
Contributor

clangenb commented Nov 5, 2024

What is a bit of a nuisance though, is that the worker registers every time upon restart. maybe the worker can check if it has been registered lately, and skip registering in order to cut down the restart time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants