Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker/Makefile to stop containers #85

Closed
antoniomtz opened this issue Jan 30, 2025 · 3 comments
Closed

Update docker/Makefile to stop containers #85

antoniomtz opened this issue Jan 30, 2025 · 3 comments
Labels
bug Something isn't working

Comments

@antoniomtz
Copy link
Contributor

The Makefile contains these instructions to stop containers, however, the containers use docker run ... so these commands will be ignore and do nothing.

start-performance-tools:
	log_dir=./results docker compose up

stop-performance-tools:
	log_dir=./results docker compose down
@antoniomtz antoniomtz added the bug Something isn't working label Jan 30, 2025
@goresant
Copy link

goresant commented Mar 3, 2025

we will work on this ticket for OSS Hackathon

@goresant
Copy link

goresant commented Mar 3, 2025

@antoniomtz We ran the start and stop commands using make command and it is working as expected
"make stop-performance-tools" deletes the containers as expected as shown below. We also observed that the results are not copied in the mounted volume. is this an issue?

root@965112f6f532:/workspaces/performance-tools/docker# make start-performance-tools
log_dir=./results docker compose up
WARN[0000] /workspaces/performance-tools/docker/docker-compose.yaml: the attribute version is obsolete, it will be ignored, please remove it to avoid potential confusion
[+] Running 3/3
✔ Network docker_default Created 0.1s
✔ Container platform Created 0.1s
✔ Container igt Created 0.1s
Attaching to igt, platform
platform | Starting platform data collection
platform | Starting sar collection
platform | Starting free collection
igt | devices found card0
platform | Starting iotop collection
igt | card0
igt |
igt | device number: 0
igt | Starting igt capture for card0 in igt0-.csv
igt | Capturing igt metrics
igt | Failed to detect engines! (No such file or directory)
igt | (Kernel 4.16 or newer is required for i915 PMU support.)
platform | Starting pcm-memory collection
platform | Starting pcm-power collection
platform | Starting general pcm collection
platform | Capturing platform data
igt | Capturing igt metrics
platform | Capturing platform data
igt | Capturing igt metrics
platform | Capturing platform data
Gracefully stopping... (press Ctrl+C again to force)
[+] Stopping 2/2
✔ Container igt Stopped 10.3s
✔ Container platform Stopped 10.4s

@antoniomtz
Copy link
Contributor Author

Makefile is not being use. docker-compose file is used by benchmark.py script and handles up and down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants