fix: unknown values in metrics cvedb

Author: Saksham-Sirohi

cve_bin_tool/cvedb.py

@@ -218,6 +218,12 @@ class CVEDB:
             VALUES (?, ?)
         """,
     }
+    METRICS = [
+        (UNKNOWN_METRIC_ID, "UNKNOWN"),
+        (EPSS_METRIC_ID, "EPSS"),
+        (CVSS_2_METRIC_ID, "CVSS-2"),
+        (CVSS_3_METRIC_ID, "CVSS-3"),
+    ]
 
     def __init__(
         self,
@@ -368,7 +374,6 @@ def latest_schema(
 
         # getting schema from command
         lines = table_schema.split("(")[1].split(",")
-
         table_schema = [x.split("\n")[1].strip().split(" ")[0] for x in lines]
         table_schema.pop()
 
@@ -378,13 +383,16 @@ def latest_schema(
         if table_schema == current_schema:
             schema_latest = True
 
-        # Check for metrics table schema
+        # Check for metrics table data integrity
         if table_name == "metrics":
-            result = cursor.execute(
-                "SELECT * FROM metrics WHERE metrics_id=?", (UNKNOWN_METRIC_ID,)
-            )
-            if not result.fetchone():
-                schema_latest = False
+            for metric_id, metric_name in self.METRICS:
+                result = cursor.execute(
+                    "SELECT * FROM metrics WHERE metrics_id=? AND metrics_name=?",
+                    (metric_id, metric_name),
+                )
+                if not result.fetchone():
+                    schema_latest = False
+                    break  # Early exit if any metric is missing
 
         return schema_latest
 
@@ -640,16 +648,9 @@ def populate_affected(self, affected_data, cursor, data_source):
     def populate_metrics(self):
         """Adding data to metric table."""
         cursor = self.db_open_and_get_cursor()
-        # Insert a row without specifying cve_metrics_id
         insert_metrics = self.INSERT_QUERIES["insert_metrics"]
-        data = [
-            (UNKNOWN_METRIC_ID, "UNKNOWN"),
-            (EPSS_METRIC_ID, "EPSS"),
-            (CVSS_2_METRIC_ID, "CVSS-2"),
-            (CVSS_3_METRIC_ID, "CVSS-3"),
-        ]
-        # Execute the insert query for each row
-        for row in data:
+        # Use the METRICS constant to populate the table
+        for row in self.METRICS:
             cursor.execute(insert_metrics, row)
         self.connection.commit()
         self.db_close()