Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: re-enable test_SBOM in test_cli.py #3473

Closed
terriko opened this issue Oct 26, 2023 · 3 comments
Closed

test: re-enable test_SBOM in test_cli.py #3473

terriko opened this issue Oct 26, 2023 · 3 comments
Assignees
Labels
good first issue Good for newcomers hacktoberfest good issue for hacktoberfest participation tests

Comments

@terriko
Copy link
Contributor

terriko commented Oct 26, 2023

We've had one of the SBOM tests disabled due to an issue that's since been fixed, so it's time to re-enable the test.

The test is in test/test_cli.py and it's named test_SBOM

To re-enable it, you'll need to remove the following line above the function:

    @pytest.mark.skip(reason="Needs database rebuild. Temporary fix.")

And @anthonyharrison indicates that we'll need to change the assertion text to indicate that it's now expected to only find 1 product with known cves. Right now it says 3:

            "There are 3 products with known CVEs detected",

That should be it -- two lines of change! I'll flag this as a good first issue and suitable for hacktoberfest folk.

@terriko terriko added good first issue Good for newcomers hacktoberfest good issue for hacktoberfest participation tests labels Oct 26, 2023
@Anurag-Nagpal
Copy link
Contributor

Hi @terriko, can you please review this PR #3474 thanks

@inosmeet
Copy link
Contributor

inosmeet commented Feb 3, 2024

This one should be fixed by #3474.

@terriko
Copy link
Contributor Author

terriko commented Feb 5, 2024

Apparently they weren't linked correctly so it didn't auto-close. Thanks for the heads up @Dev-Voldemort ; I'll close this now.

@terriko terriko closed this as completed Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest good issue for hacktoberfest participation tests
Projects
None yet
Development

No branches or pull requests

3 participants