Skip to content

Commit 263a987

Browse files
Apply comments
1 parent e0eb498 commit 263a987

File tree

4 files changed

+9
-1
lines changed

4 files changed

+9
-1
lines changed

sycl/include/CL/sycl/detail/pi.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
//
4545
#include "CL/cl.h"
4646
#define _PI_H_VERSION_MAJOR 5
47-
#define _PI_H_VERSION_MINOR 7
47+
#define _PI_H_VERSION_MINOR 8
4848

4949
#define _PI_STRING_HELPER(a) #a
5050
#define _PI_CONCAT(a, b) _PI_STRING_HELPER(a.b)

sycl/plugins/cuda/pi_cuda.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2252,6 +2252,9 @@ pi_result cuda_piQueueFinish(pi_queue command_queue) {
22522252
return result;
22532253
}
22542254

2255+
// There is no CUDA counterpart for queue flushing and we don't run into the
2256+
// same problem of having to flush cross-queue dependencies as some of the
2257+
// other plugins, so it can be left as no-op.
22552258
pi_result cuda_piQueueFlush(pi_queue command_queue) { return PI_SUCCESS; }
22562259

22572260
/// Gets the native CUDA handle of a PI queue object

sycl/plugins/hip/pi_hip.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2202,6 +2202,9 @@ pi_result hip_piQueueFinish(pi_queue command_queue) {
22022202
return result;
22032203
}
22042204

2205+
// There is no HIP counterpart for queue flushing and we don't run into the
2206+
// same problem of having to flush cross-queue dependencies as some of the
2207+
// other plugins, so it can be left as no-op.
22052208
pi_result hip_piQueueFlush(pi_queue command_queue) { return PI_SUCCESS; }
22062209

22072210
/// Gets the native HIP handle of a PI queue object

sycl/plugins/level_zero/pi_level_zero.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2997,6 +2997,8 @@ pi_result piQueueFinish(pi_queue Queue) {
29972997
return PI_SUCCESS;
29982998
}
29992999

3000+
// Flushing cross-queue dependencies is covered by createAndRetainPiZeEventList,
3001+
// so this can be left as a no-op.
30003002
pi_result piQueueFlush(pi_queue Queue) { return PI_SUCCESS; }
30013003

30023004
pi_result piextQueueGetNativeHandle(pi_queue Queue,

0 commit comments

Comments
 (0)