[SYCL] fix incorrect application of binary AND in tests (#16610)

&= with 0 is always 0. For tests that are returning 0 as success, using
binary AND will mask errors, leading the test to incorrectly pass when
it should fail. I wasted an hour last week being mislead by this
problem. I audited all our tests and fortunately the ones making this
mistake were relatively few.

Author: cperkinsintel

sycl/test-e2e/Basic/fpga_tests/fpga_pipes.cpp

@@ -329,26 +329,26 @@ int main() {
   }
 
   // Non-blocking pipes
-  int Result = test_simple_nb_pipe<some_nb_pipe, /*test number*/ 1>(Queue);
-  Result &= test_simple_nb_pipe<some::nb_pipe, /*test number*/ 2>(Queue);
+  int Error = test_simple_nb_pipe<some_nb_pipe, /*test number*/ 1>(Queue);
+  Error |= test_simple_nb_pipe<some::nb_pipe, /*test number*/ 2>(Queue);
   class forward_nb_pipe;
-  Result &= test_simple_nb_pipe<forward_nb_pipe, /*test number*/ 3>(Queue);
-  Result &= test_simple_nb_pipe<templ_nb_pipe<0>, /*test number*/ 4>(Queue);
-  Result &= test_multiple_nb_pipe</*test number*/ 5>(Queue);
+  Error |= test_simple_nb_pipe<forward_nb_pipe, /*test number*/ 3>(Queue);
+  Error |= test_simple_nb_pipe<templ_nb_pipe<0>, /*test number*/ 4>(Queue);
+  Error |= test_multiple_nb_pipe</*test number*/ 5>(Queue);
 
   // Blocking pipes
-  Result &= test_simple_bl_pipe<some_bl_pipe, /*test number*/ 6>(Queue);
-  Result &= test_simple_bl_pipe<some::bl_pipe, /*test number*/ 7>(Queue);
+  Error |= test_simple_bl_pipe<some_bl_pipe, /*test number*/ 6>(Queue);
+  Error |= test_simple_bl_pipe<some::bl_pipe, /*test number*/ 7>(Queue);
   class forward_bl_pipe;
-  Result &= test_simple_bl_pipe<forward_bl_pipe, /*test number*/ 8>(Queue);
-  Result &= test_simple_bl_pipe<templ_bl_pipe<0>, /*test number*/ 9>(Queue);
-  Result &= test_multiple_bl_pipe</*test number*/ 10>(Queue);
+  Error |= test_simple_bl_pipe<forward_bl_pipe, /*test number*/ 8>(Queue);
+  Error |= test_simple_bl_pipe<templ_bl_pipe<0>, /*test number*/ 9>(Queue);
+  Error |= test_multiple_bl_pipe</*test number*/ 10>(Queue);
 
   // Test for an array data passing through a pipe
-  Result &= test_array_th_nb_pipe</*test number*/ 11>(Queue);
-  Result &= test_array_th_bl_pipe</*test number*/ 12>(Queue);
+  Error |= test_array_th_nb_pipe</*test number*/ 11>(Queue);
+  Error |= test_array_th_bl_pipe</*test number*/ 12>(Queue);
 
   // TODO Remove when #14308 is closed
-  std::cerr << "DEBUG: Finished with result " << Result << std::endl;
-  return Result;
+  std::cerr << "DEBUG: Finished with result " << Error << std::endl;
+  return Error;
 }

sycl/test-e2e/Basic/launch_queries/max_num_work_groups.cpp

@@ -206,8 +206,8 @@ int main() {
 
   using namespace kernels;
 
-  int ret{0};
-  ret &= test_max_num_work_groups<TestKernel>(q, dev);
-  ret &= test_max_num_work_groups<TestLocalMemoryKernel>(q, dev);
-  return ret;
+  int Error{0};
+  Error |= test_max_num_work_groups<TestKernel>(q, dev);
+  Error |= test_max_num_work_groups<TestLocalMemoryKernel>(q, dev);
+  return Error;
 }

sycl/test-e2e/Scheduler/MultipleDevices.cpp

@@ -92,30 +92,30 @@ int multidevice_test(queue MyQueue1, queue MyQueue2) {
 
 int main() {
 
-  int Result = -1;
+  int Error = 0;
   try {
     queue MyQueue1(cpu_selector_v);
     queue MyQueue2(cpu_selector_v);
-    Result &= multidevice_test(MyQueue1, MyQueue2);
+    Error |= multidevice_test(MyQueue1, MyQueue2);
   } catch (sycl::exception &) {
     std::cout << "Skipping CPU and CPU" << std::endl;
   }
 
   try {
     queue MyQueue1(cpu_selector_v);
     queue MyQueue2(gpu_selector_v);
-    Result &= multidevice_test(MyQueue1, MyQueue2);
+    Error |= multidevice_test(MyQueue1, MyQueue2);
   } catch (sycl::exception &) {
     std::cout << "Skipping CPU and GPU" << std::endl;
   }
 
   try {
     queue MyQueue1(gpu_selector_v);
     queue MyQueue2(gpu_selector_v);
-    Result &= multidevice_test(MyQueue1, MyQueue2);
+    Error |= multidevice_test(MyQueue1, MyQueue2);
   } catch (sycl::exception &) {
     std::cout << "Skipping GPU and GPU" << std::endl;
   }
 
-  return Result;
+  return Error;
 }

sycl/test-e2e/XPTI/buffer/in_cycle.cpp

@@ -45,7 +45,7 @@ bool func(sycl::queue &Queue, int depth = 0) {
   }
 
   if (depth > 0)
-    MismatchFound &= func(Queue, depth - 1);
+    MismatchFound |= func(Queue, depth - 1);
   return MismatchFound;
 }
 int main() {
@@ -66,7 +66,7 @@ int main() {
   // CHECK:{{[0-9]+}}|Release buffer|[[USERID3]]|[[BEID3]]
   // CHECK:{{[0-9]+}}|Destruct buffer|[[USERID3]]
   for (int i = 0; i < 3; i++)
-    MismatchFound &= func(Queue);
+    MismatchFound |= func(Queue);
   return MismatchFound;
 }
 

sycl/test-e2e/XPTI/buffer/recursion.cpp

@@ -65,7 +65,7 @@ int main() {
   // CHECK:{{[0-9]+}}|Destruct buffer|[[USERID2]]
   // CHECK:{{[0-9]+}}|Release buffer|[[USERID1]]|[[BEID1]]
   // CHECK:{{[0-9]+}}|Destruct buffer|[[USERID1]]
-  MismatchFound &= func(Queue, 2);
+  MismatchFound |= func(Queue, 2);
 
   return MismatchFound;
 }

sycl/test/fpga_tests/fpga_io_pipes.cpp

@@ -123,10 +123,10 @@ int main() {
   }
 
   // Non-blocking pipes
-  int Result = test_io_nb_pipe(Queue);
+  int Error = test_io_nb_pipe(Queue); // 0 if successful
 
   // Blocking pipes
-  Result &= test_io_bl_pipe(Queue);
+  Error |= test_io_bl_pipe(Queue);
 
-  return Result;
+  return Error;
 }