Skip to content

Commit 61bb39e

Browse files
committed
[Benchmarks] Fix SubmitGraph CPU count scenarios grouping
Fixes SubmitGraph CPU count scenarios being drawed in the same charts as SubmitGraph time measurement scenarios making them hard to read.
1 parent 1034206 commit 61bb39e

File tree

1 file changed

+28
-6
lines changed

1 file changed

+28
-6
lines changed

devops/scripts/benchmarks/benches/compute.py

Lines changed: 28 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -164,12 +164,18 @@ def additional_metadata(self) -> dict[str, BenchmarkMetadata]:
164164
for completion in ["", " with completion"]:
165165
for events in ["", " using events"]:
166166
for num_kernels in self.submit_graph_num_kernels:
167-
group_name = f"SubmitGraph {order}{completion}{events}, {num_kernels} kernels"
168-
metadata[group_name] = BenchmarkMetadata(
169-
type="group",
170-
tags=base_metadata.tags,
171-
)
172-
167+
for host_tasks in ["", " use host tasks"]:
168+
group_name = f"SubmitGraph {order}{completion}{events}{host_tasks}, {num_kernels} kernels"
169+
metadata[group_name] = BenchmarkMetadata(
170+
type="group",
171+
tags=base_metadata.tags,
172+
)
173+
# CPU count variants
174+
cpu_count_group = f"{group_name}, CPU count"
175+
metadata[cpu_count_group] = BenchmarkMetadata(
176+
type="group",
177+
tags=base_metadata.tags,
178+
)
173179
return metadata
174180

175181
def benchmarks(self) -> list[Benchmark]:
@@ -1098,6 +1104,22 @@ def bin_args(self, run_trace: TracingType = TracingType.NONE) -> list[str]:
10981104
bin_args.append(f"--profilerType={self.profiler_type.value}")
10991105
return bin_args
11001106

1107+
def get_metadata(self) -> dict[str, BenchmarkMetadata]:
1108+
metadata_dict = super().get_metadata()
1109+
1110+
# Create CPU count variant with modified display name and explicit_group
1111+
cpu_count_name = self.name() + " CPU count"
1112+
cpu_count_metadata = copy.deepcopy(metadata_dict[self.name()])
1113+
cpu_count_display_name = self.display_name() + ", CPU count"
1114+
cpu_count_explicit_group = (
1115+
self.explicit_group() + ", CPU count" if self.explicit_group() else ""
1116+
)
1117+
cpu_count_metadata.display_name = cpu_count_display_name
1118+
cpu_count_metadata.explicit_group = cpu_count_explicit_group
1119+
metadata_dict[cpu_count_name] = cpu_count_metadata
1120+
1121+
return metadata_dict
1122+
11011123

11021124
class UllsEmptyKernel(ComputeBenchmark):
11031125
def __init__(

0 commit comments

Comments
 (0)