Skip to content

Commit 960b1ca

Browse files
author
Ewan Crawford
authored
[SYCL][Graph] Fix bugs with HIP/CUDA UR sync points. (#14858)
Tests UR PR oneapi-src/unified-runtime#1910
1 parent 50a03c5 commit 960b1ca

File tree

2 files changed

+22
-6
lines changed

2 files changed

+22
-6
lines changed

sycl/cmake/modules/FetchUnifiedRuntime.cmake

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -117,13 +117,13 @@ if(SYCL_PI_UR_USE_FETCH_CONTENT)
117117
endfunction()
118118

119119
set(UNIFIED_RUNTIME_REPO "https://github.com/oneapi-src/unified-runtime.git")
120-
# commit 83f7ad9551ce0134931b44804b5a254ae2e93068
121-
# Merge: ab9baf57 8fb6824d
120+
# commit 3c12bbceec33cf5cf5fc4fa85e641b4f95e820b7
121+
# Merge: 83f7ad95 ac7eb171
122122
# Author: Omar Ahmed <omar.ahmed@codeplay.com>
123-
# Date: Thu Aug 8 11:11:13 2024 +0100
124-
# Merge pull request #1860 from PietroGhg/pietro/fill
125-
# [NATIVECPU] Fix pointer arithmetic in USMfill
126-
set(UNIFIED_RUNTIME_TAG 83f7ad9551ce0134931b44804b5a254ae2e93068)
123+
# Date: Fri Aug 9 10:51:05 2024 +0100
124+
# Merge pull request #1910 from Bensuo/sync_point
125+
# [CUDA][HIP] Improve command-buffer sync points
126+
set(UNIFIED_RUNTIME_TAG 3c12bbceec33cf5cf5fc4fa85e641b4f95e820b7)
127127

128128
set(UMF_BUILD_EXAMPLES OFF CACHE INTERNAL "EXAMPLES")
129129
# Due to the use of dependentloadflag and no installer for UMF and hwloc we need

sycl/doc/design/CommandGraph.md

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -480,6 +480,14 @@ An executable CUDA Graph, which contains all commands and synchronization
480480
information, is saved in the UR command-buffer to allow for efficient graph
481481
resubmission.
482482

483+
#### Prefetch & Advise
484+
485+
The `urCommandBufferAppendUSMPrefetchExp` and
486+
`urCommandBufferAppendUSMAdviseExp` UR entry-points used to implement
487+
`handler::prefetch` and `handler::mem_advise` are implemented in the CUDA UR
488+
adapter as empty nodes enforcing the node dependencies. As such the
489+
optimization hints are a no-op.
490+
483491
### HIP
484492

485493
The HIP backend offers a graph management API very similar to CUDA Graph
@@ -502,6 +510,14 @@ An executable HIP Graph, which contains all commands and synchronization
502510
information, is saved in the UR command-buffer to allow for efficient
503511
graph resubmission.
504512

513+
#### Prefetch & Advise
514+
515+
The `urCommandBufferAppendUSMPrefetchExp` and
516+
`urCommandBufferAppendUSMAdviseExp` UR entry-points used to implement
517+
`handler::prefetch` and `handler::mem_advise` are implemented in the HIP UR
518+
adapter as empty nodes enforcing the node dependencies. As such the
519+
optimization hints are a no-op.
520+
505521
### OpenCL
506522

507523
SYCL-Graph is only enabled for an OpenCL backend when the

0 commit comments

Comments
 (0)