Skip to content

Commit e0f59e3

Browse files
authored
[SYCL] Handle massive warnings comming from DPCPP lib (#1583)
Signed-off-by: Aleksander Fadeev <aleksander.fadeev@intel.com>
1 parent 2a4c1c8 commit e0f59e3

30 files changed

+207
-112
lines changed

sycl/include/CL/__spirv/spirv_ops.hpp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -235,9 +235,9 @@ __spirv_ocl_prefetch(const __attribute__((opencl_global)) char *Ptr,
235235

236236
template <typename dataT>
237237
__SYCL_CONVERGENT__ extern __ocl_event_t
238-
OpGroupAsyncCopyGlobalToLocal(__spv::Scope::Flag Execution, dataT *Dest,
239-
dataT *Src, size_t NumElements, size_t Stride,
240-
__ocl_event_t E) noexcept {
238+
OpGroupAsyncCopyGlobalToLocal(__spv::Scope::Flag, dataT *Dest, dataT *Src,
239+
size_t NumElements, size_t Stride,
240+
__ocl_event_t) noexcept {
241241
for (size_t i = 0; i < NumElements; i++) {
242242
Dest[i] = Src[i * Stride];
243243
}
@@ -247,9 +247,9 @@ OpGroupAsyncCopyGlobalToLocal(__spv::Scope::Flag Execution, dataT *Dest,
247247

248248
template <typename dataT>
249249
__SYCL_CONVERGENT__ extern __ocl_event_t
250-
OpGroupAsyncCopyLocalToGlobal(__spv::Scope::Flag Execution, dataT *Dest,
251-
dataT *Src, size_t NumElements, size_t Stride,
252-
__ocl_event_t E) noexcept {
250+
OpGroupAsyncCopyLocalToGlobal(__spv::Scope::Flag, dataT *Dest, dataT *Src,
251+
size_t NumElements, size_t Stride,
252+
__ocl_event_t) noexcept {
253253
for (size_t i = 0; i < NumElements; i++) {
254254
Dest[i * Stride] = Src[i];
255255
}

sycl/include/CL/sycl/accessor.hpp

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -387,6 +387,8 @@ class image_accessor
387387
image_accessor(image<Dims, AllocatorT> &ImageRef, int ImageElementSize)
388388
#ifdef __SYCL_DEVICE_ONLY__
389389
{
390+
(void)ImageRef;
391+
(void)ImageElementSize;
390392
// No implementation needed for device. The constructor is only called by
391393
// host.
392394
}
@@ -415,6 +417,9 @@ class image_accessor
415417
handler &CommandGroupHandlerRef, int ImageElementSize)
416418
#ifdef __SYCL_DEVICE_ONLY__
417419
{
420+
(void)ImageRef;
421+
(void)CommandGroupHandlerRef;
422+
(void)ImageElementSize;
418423
// No implementation needed for device. The constructor is only called by
419424
// host.
420425
}
@@ -784,6 +789,7 @@ class accessor :
784789
handler &CommandGroupHandler)
785790
#ifdef __SYCL_DEVICE_ONLY__
786791
: impl(id<AdjustedDim>(), range<1>{1}, BufferRef.get_range()) {
792+
(void)CommandGroupHandler;
787793
}
788794
#else
789795
: AccessorBaseHost(
@@ -824,6 +830,7 @@ class accessor :
824830
handler &CommandGroupHandler)
825831
#ifdef __SYCL_DEVICE_ONLY__
826832
: impl(id<AdjustedDim>(), BufferRef.get_range(), BufferRef.get_range()) {
833+
(void)CommandGroupHandler;
827834
}
828835
#else
829836
: AccessorBaseHost(
@@ -867,6 +874,7 @@ class accessor :
867874
id<Dimensions> AccessOffset = {})
868875
#ifdef __SYCL_DEVICE_ONLY__
869876
: impl(AccessOffset, AccessRange, BufferRef.get_range()) {
877+
(void)CommandGroupHandler;
870878
}
871879
#else
872880
: AccessorBaseHost(detail::convertToArrayOfN<3, 0>(AccessOffset),
@@ -1033,7 +1041,7 @@ class accessor<DataT, Dimensions, AccessMode, access::target::local,
10331041
const sycl::range<AdjustedDim> &getSize() const { return impl.MemRange; }
10341042

10351043
void __init(ConcreteASPtrType Ptr, range<AdjustedDim> AccessRange,
1036-
range<AdjustedDim> MemRange, id<AdjustedDim> Offset) {
1044+
range<AdjustedDim>, id<AdjustedDim>) {
10371045
MData = Ptr;
10381046
for (int I = 0; I < AdjustedDim; ++I)
10391047
getSize()[I] = AccessRange[I];
@@ -1075,7 +1083,7 @@ class accessor<DataT, Dimensions, AccessMode, access::target::local,
10751083
using const_reference = const DataT &;
10761084

10771085
template <int Dims = Dimensions, typename = detail::enable_if_t<Dims == 0>>
1078-
accessor(handler &CommandGroupHandler)
1086+
accessor(handler &)
10791087
#ifdef __SYCL_DEVICE_ONLY__
10801088
: impl(range<AdjustedDim>{1}) {
10811089
}
@@ -1085,7 +1093,7 @@ class accessor<DataT, Dimensions, AccessMode, access::target::local,
10851093
#endif
10861094

10871095
template <int Dims = Dimensions, typename = detail::enable_if_t<(Dims > 0)>>
1088-
accessor(range<Dimensions> AllocationSize, handler &CommandGroupHandler)
1096+
accessor(range<Dimensions> AllocationSize, handler &)
10891097
#ifdef __SYCL_DEVICE_ONLY__
10901098
: impl(AllocationSize) {
10911099
}
@@ -1271,6 +1279,7 @@ struct hash<cl::sycl::accessor<DataT, Dimensions, AccessMode, AccessTarget,
12711279
size_t operator()(const AccType &A) const {
12721280
#ifdef __SYCL_DEVICE_ONLY__
12731281
// Hash is not supported on DEVICE. Just return 0 here.
1282+
(void)A;
12741283
return 0;
12751284
#else
12761285
// getSyclObjImpl() here returns a pointer to either AccessorImplHost

sycl/include/CL/sycl/atomic.hpp

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -73,10 +73,10 @@ namespace detail {
7373
// into std::memory_order
7474
// Only relaxed memory semantics are supported currently
7575
static inline std::memory_order
76-
getStdMemoryOrder(__spv::MemorySemanticsMask::Flag MS) {
76+
getStdMemoryOrder(__spv::MemorySemanticsMask::Flag) {
7777
return std::memory_order_relaxed;
7878
}
79-
static inline std::memory_order getStdMemoryOrder(::cl::sycl::memory_order MS) {
79+
static inline std::memory_order getStdMemoryOrder(::cl::sycl::memory_order) {
8080
return std::memory_order_relaxed;
8181
}
8282
} // namespace detail
@@ -86,55 +86,55 @@ static inline std::memory_order getStdMemoryOrder(::cl::sycl::memory_order MS) {
8686
// std::atomic version of atomic SPIR-V builtins
8787

8888
template <typename T>
89-
void __spirv_AtomicStore(std::atomic<T> *Ptr, __spv::Scope::Flag S,
89+
void __spirv_AtomicStore(std::atomic<T> *Ptr, __spv::Scope::Flag,
9090
__spv::MemorySemanticsMask::Flag MS, T V) {
9191
Ptr->store(V, ::cl::sycl::detail::getStdMemoryOrder(MS));
9292
}
9393

9494
template <typename T>
95-
T __spirv_AtomicLoad(const std::atomic<T> *Ptr, __spv::Scope::Flag S,
95+
T __spirv_AtomicLoad(const std::atomic<T> *Ptr, __spv::Scope::Flag,
9696
__spv::MemorySemanticsMask::Flag MS) {
9797
return Ptr->load(::cl::sycl::detail::getStdMemoryOrder(MS));
9898
}
9999

100100
template <typename T>
101-
T __spirv_AtomicExchange(std::atomic<T> *Ptr, __spv::Scope::Flag S,
101+
T __spirv_AtomicExchange(std::atomic<T> *Ptr, __spv::Scope::Flag,
102102
__spv::MemorySemanticsMask::Flag MS, T V) {
103103
return Ptr->exchange(V, ::cl::sycl::detail::getStdMemoryOrder(MS));
104104
}
105105

106106
template <typename T>
107-
extern T __spirv_AtomicIAdd(std::atomic<T> *Ptr, __spv::Scope::Flag S,
107+
extern T __spirv_AtomicIAdd(std::atomic<T> *Ptr, __spv::Scope::Flag,
108108
__spv::MemorySemanticsMask::Flag MS, T V) {
109109
return Ptr->fetch_add(V, ::cl::sycl::detail::getStdMemoryOrder(MS));
110110
}
111111

112112
template <typename T>
113-
extern T __spirv_AtomicISub(std::atomic<T> *Ptr, __spv::Scope::Flag S,
113+
extern T __spirv_AtomicISub(std::atomic<T> *Ptr, __spv::Scope::Flag,
114114
__spv::MemorySemanticsMask::Flag MS, T V) {
115115
return Ptr->fetch_sub(V, ::cl::sycl::detail::getStdMemoryOrder(MS));
116116
}
117117

118118
template <typename T>
119-
extern T __spirv_AtomicAnd(std::atomic<T> *Ptr, __spv::Scope::Flag S,
119+
extern T __spirv_AtomicAnd(std::atomic<T> *Ptr, __spv::Scope::Flag,
120120
__spv::MemorySemanticsMask::Flag MS, T V) {
121121
return Ptr->fetch_and(V, ::cl::sycl::detail::getStdMemoryOrder(MS));
122122
}
123123

124124
template <typename T>
125-
extern T __spirv_AtomicOr(std::atomic<T> *Ptr, __spv::Scope::Flag S,
125+
extern T __spirv_AtomicOr(std::atomic<T> *Ptr, __spv::Scope::Flag,
126126
__spv::MemorySemanticsMask::Flag MS, T V) {
127127
return Ptr->fetch_or(V, ::cl::sycl::detail::getStdMemoryOrder(MS));
128128
}
129129

130130
template <typename T>
131-
extern T __spirv_AtomicXor(std::atomic<T> *Ptr, __spv::Scope::Flag S,
131+
extern T __spirv_AtomicXor(std::atomic<T> *Ptr, __spv::Scope::Flag,
132132
__spv::MemorySemanticsMask::Flag MS, T V) {
133133
return Ptr->fetch_xor(V, ::cl::sycl::detail::getStdMemoryOrder(MS));
134134
}
135135

136136
template <typename T>
137-
extern T __spirv_AtomicMin(std::atomic<T> *Ptr, __spv::Scope::Flag S,
137+
extern T __spirv_AtomicMin(std::atomic<T> *Ptr, __spv::Scope::Flag,
138138
__spv::MemorySemanticsMask::Flag MS, T V) {
139139
std::memory_order MemoryOrder = ::cl::sycl::detail::getStdMemoryOrder(MS);
140140
T Val = Ptr->load(MemoryOrder);
@@ -147,7 +147,7 @@ extern T __spirv_AtomicMin(std::atomic<T> *Ptr, __spv::Scope::Flag S,
147147
}
148148

149149
template <typename T>
150-
extern T __spirv_AtomicMax(std::atomic<T> *Ptr, __spv::Scope::Flag S,
150+
extern T __spirv_AtomicMax(std::atomic<T> *Ptr, __spv::Scope::Flag,
151151
__spv::MemorySemanticsMask::Flag MS, T V) {
152152
std::memory_order MemoryOrder = ::cl::sycl::detail::getStdMemoryOrder(MS);
153153
T Val = Ptr->load(MemoryOrder);

sycl/include/CL/sycl/buffer.hpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -337,8 +337,7 @@ class buffer {
337337
return outOfBounds;
338338
}
339339

340-
bool isContiguousRegion(const id<1> &offset, const range<1> &newRange,
341-
const range<1> &parentRange) {
340+
bool isContiguousRegion(const id<1> &, const range<1> &, const range<1> &) {
342341
// 1D sub buffer always has contiguous region
343342
return true;
344343
}

sycl/include/CL/sycl/detail/aligned_allocator.hpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,13 +63,13 @@ template <typename T> class aligned_allocator {
6363
}
6464

6565
// Release allocated memory
66-
void deallocate(pointer Ptr, size_t size) {
66+
void deallocate(pointer Ptr, size_t) {
6767
if (Ptr)
6868
detail::OSUtil::alignedFree(Ptr);
6969
}
7070

71-
bool operator==(const aligned_allocator&) { return true; }
72-
bool operator!=(const aligned_allocator& rhs) { return false; }
71+
bool operator==(const aligned_allocator &) { return true; }
72+
bool operator!=(const aligned_allocator &) { return false; }
7373

7474
void setAlignment(size_t Alignment) { MAlignment = Alignment; }
7575

sycl/include/CL/sycl/detail/array.hpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -115,6 +115,7 @@ template <int dimensions = 1> class array {
115115
PI_INVALID_VALUE);
116116
}
117117
#endif
118+
(void)dimension;
118119
}
119120
};
120121

sycl/include/CL/sycl/detail/buffer_impl.hpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,7 @@ class __SYCL_EXPORT buffer_impl final : public SYCLMemObjT {
4343
using typename BaseT::MemObjType;
4444

4545
public:
46-
buffer_impl(size_t SizeInBytes, size_t RequiredAlign,
47-
const property_list &Props,
46+
buffer_impl(size_t SizeInBytes, size_t, const property_list &Props,
4847
unique_ptr_class<SYCLMemObjAllocator> Allocator)
4948
: BaseT(SizeInBytes, Props, std::move(Allocator)) {}
5049

sycl/include/CL/sycl/detail/cg.hpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -251,7 +251,7 @@ class HostKernel : public HostKernelBase {
251251
// If local size for host is not set explicitly, let's adjust it to 1,
252252
// so nd_range_error for zero local size is not thrown.
253253
if (AdjustedRange.LocalSize[0] == 0)
254-
for (int I = 0; I < AdjustedRange.Dims; ++I)
254+
for (size_t I = 0; I < AdjustedRange.Dims; ++I)
255255
AdjustedRange.LocalSize[I] = 1;
256256
if (HPI)
257257
HPI->start();
@@ -264,7 +264,7 @@ class HostKernel : public HostKernelBase {
264264

265265
template <class ArgT = KernelArgType>
266266
typename std::enable_if<std::is_same<ArgT, void>::value>::type
267-
runOnHost(const NDRDescT &NDRDesc) {
267+
runOnHost(const NDRDescT &) {
268268
MKernel();
269269
}
270270

sycl/include/CL/sycl/detail/image_accessor_util.hpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,8 +78,7 @@ convertToFloat4(vec<T, 4> Coords) {
7878
// ptr.
7979
template <typename T>
8080
detail::enable_if_t<std::is_integral<T>::value, size_t>
81-
getImageOffset(const T &Coords, const id<3> ImgPitch,
82-
const uint8_t ElementSize) {
81+
getImageOffset(const T &Coords, const id<3>, const uint8_t ElementSize) {
8382
return Coords * ElementSize;
8483
}
8584

sycl/include/CL/sycl/detail/image_impl.hpp

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -242,9 +242,7 @@ class __SYCL_EXPORT image_impl final : public SYCLMemObjT {
242242
});
243243
}
244244

245-
template <typename T, typename... Args> bool checkAnyImpl(T Value) {
246-
return false;
247-
}
245+
template <typename T, typename... Args> bool checkAnyImpl(T) { return false; }
248246

249247
template <typename ValT, typename VarT, typename... Args>
250248
bool checkAnyImpl(ValT Value, VarT Variant, Args... Arguments) {

0 commit comments

Comments
 (0)