Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL] "Assuming SYCL queries fit in int" feature is broken for -O1 #3263

Open
vmaksimo opened this issue Feb 25, 2021 · 1 comment
Open
Labels
bug Something isn't working confirmed

Comments

@vmaksimo
Copy link
Contributor

Describe the bug
https://github.com/intel/llvm/blob/sycl/sycl/test/check_device_code/id_queries_fit_int.cpp test fails after community changes (#3233). "llvm.assume" intrinsic is not generated with O1 optimization level as it expected from test checks.
I temporarily disabled optimizations to unlock pulldown 18b3ac2

To Reproduce

# If the https://github.com/intel/llvm/pull/3233 is not merged yet, fetch the PR:
git fetch origin pull/3233/head:pr_3233
git checkout pr_3233

# Then revert the commit that disables the test
git revert 18b3ac2e317696c066744981d719f4268674365c 

# Then build with the normal procedure https://github.com/intel/llvm/blob/sycl/sycl/doc/GetStartedGuide.md#build-dpc-toolchain
python $DPCPP_HOME/llvm/buildbot/configure.py
python $DPCPP_HOME/llvm/buildbot/compile.py

# And run the tests
python $DPCPP_HOME/llvm/buildbot/check.py
@AlexeySachkov
Copy link
Contributor

The test has been refactored since then and the most notable change is complete disabling of FE optimizations done in #3751

The test should work in any optimization level - if I remember correctly, those hints were important for backend optimizations, so the lack of them when optimizations are enabled means that the whole feature doesn't work.

I think that this may still be an actual issue and we need to at least extend the test to run in all possible optimization levels to be sure that everything works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working confirmed
Projects
None yet
Development

No branches or pull requests

3 participants