-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug][DG2][VPP]: tonemap_vaapi extremely slow on certain input size 1280*(722 vs 720) #1628
Comments
@FurongZhang May need to trouble you to look into it. Thanks in advance. |
Auto Created VSMGWL-62709 for further analysis. |
Does not look like an alignment issue, at least not a straight-forward one. While fast 720 height is divisible by 16, 694 is only by 2, whereas slow 692 height is divisible by 4... |
Indeed. So I haven't found the pattern of this issue. |
@nyanmisaka , well received the information, will update the status ww13. |
Any news on this? I see that the LUT media kernel has been updated recently but it doesn't seem to help this issue. |
The fix code #1646 has been merged and upstreamed. |
@FurongZhang Tested and it works just fine now. Thanks for your help! |
@nyanmisaka , glad to know that. You are very welcome. |
@nyanmisaka I built media-driver 23.2.2 (which contains this fix), installed it in the OS, then replaced /usr/lib/jellyfin-ffmpeg/lib/dri/iHD_drv_video.so with the newly built version (build_media/media_driver/iHD_drv_video.so), restarted the service, played a cropped 4k HDR (height divisible by 2) needing tone mapping, and I am still running into this issue. I am transcoding on an i7-13700k cpu/igpu. I am on jellyfin-ffmpeg-5.1.3-1-jammy. The input resolution of the file I'm having trouble with is 3840x1604 and the output resolution is 1920x802.
I'm sure it's me, just wondering if I missed a way to deploy this change. If there's a better place to discuss this, apologies - couldn't find a related issue in the jellyfin-ffmpeg or jellyfin github projects. |
We can discuss here in jellyfin repo jellyfin/jellyfin-ffmpeg#245 |
?? Need to update driver. We fixed this issue in driver. |
@FurongZhang It's a different issue on RPL-S / 13th Gen.
Edit:
|
With the latest media-driver from master, I still only get <1 fps when transcoding a 3840x1608 movie with VPP tonemapping. Then it fails with an Input/Output error.
happy to take this specific issue to another Issue thread as well, just let me know :) |
I can also reproduce this using a sample file from here - click on " Download the UHD HDR10 - Sony Bravia OLED File " link on that page to download/save. Then run the following 2 commands on i7-13700k or similar iGPU on ubuntu lunar with kernel 6.2 and the latest master media-driver:
|
@almightiest Can you apply this patch to master branch and try again? https://github.com/intel/media-driver/commit/d00ada51.patch |
Sorry I thought that was applied to master already. Just applied it, here's showing I have master plus this patch only:
Same issue, though. Input/Output error for the 1920x802 or 1280x692 resolutions. 1920x1080, 1920x800, 1280x694 worked fine. |
@nyanmisaka Considering it's different issue, could you create a new one? Thanks. |
@Sherry-Lin logged #1672 |
Which component impacted?
Video Processing
Is it regression? Good in old configuration?
No, this issue exist a long time
What happened?
Two bad resolutions: 1280x722 and 1280x692 - Results in very slow FPS - < 5 FPS.
But 1280x720 and 1280x694 works just fine - hundreds FPS.
Other resolutions may also affected but I haven't found the pattern yet.
What's the usage scenario when you are seeing the problem?
Transcode for media delivery
What impacted?
HDR10 to SDR tone-mapping in media delivery.
Debug Information
Guess it's due to the incorrect image size alignment on DG2 platform?
Older platforms are not affected such as KBLx and TGLx.
Other common VPP filters are not affected too.
Do you want to contribute a patch to fix the issue?
None
The text was updated successfully, but these errors were encountered: