Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Floating point square root #171

Closed
mkorbel1 opened this issue Feb 6, 2025 · 2 comments · Fixed by #188
Closed

Floating point square root #171

mkorbel1 opened this issue Feb 6, 2025 · 2 comments · Fixed by #188
Assignees
@lucasphillips
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@mkorbel1
Copy link
Contributor

mkorbel1 commented Feb 6, 2025

Motivation

Floating point units sometimes need to be able to perform a square root operation.

Desired solution

A floating-point square root component.

Alternatives considered

No response

Additional details

No response
@mkorbel1 mkorbel1 added enhancement New feature or request help wanted Extra attention is needed labels Feb 6, 2025
@lucasphillips
Copy link
Contributor

As part of the 2025 OSS Hackathon, ROHD_Team1 is working on this issue.

@mkorbel1
Copy link
Contributor Author

mkorbel1 commented Mar 3, 2025

Awesome! Assigned!

@sweeksBigBlue sweeksBigBlue mentioned this issue Mar 7, 2025
Open
lucasphillips pushed a commit to lucasphillips/rohd-hcl that referenced this issue Mar 7, 2025
@sweeksBigBlue @jcfarwe
@curtisan-intel @lucasphillips
Floating point square root
0d7d3bd 
Add a base class for floating point square root.

Implement a basic floating point square root module. Mantissa is
variable, but limited to odd numbers from 1 to 51. No rounding
implemented.

Implement a fixed point square root for values with three integral bits
and up to 51 fractional bits.

Add a fixed point square root method.

Add tests for fixed-point and floating-point square root.

Implements intel#171

Co-authored-by: James Farwell <james.c.farwell@intel.com>
Co-authored-by: Curtis Anderson <curtis.anderson@intel.com>
Signed-off-by: Stephen Weeks <stephen.weeks@intel.com>
Signed-off-by: James Farwell <james.c.farwell@intel.com>
Signed-off-by: Curtis Anderson <curtis.anderson@intel.com>
lucasphillips pushed a commit to lucasphillips/rohd-hcl that referenced this issue Mar 7, 2025
@sweeksBigBlue @jcfarwe
@curtisan-intel @lucasphillips
Floating point square root
cf0ccef 
Add a base class for floating point square root.

Implement a basic floating point square root module. Mantissa is
variable, but limited to odd numbers from 1 to 51. No rounding
implemented.

Implement a fixed point square root for values with three integral bits
and up to 51 fractional bits.

Add a fixed point square root method.

Add tests for fixed-point and floating-point square root.

Implements intel#171

Co-authored-by: James Farwell <james.c.farwell@intel.com>
Co-authored-by: Curtis Anderson <curtis.anderson@intel.com>
Signed-off-by: Stephen Weeks <stephen.weeks@intel.com>
Signed-off-by: James Farwell <james.c.farwell@intel.com>
Signed-off-by: Curtis Anderson <curtis.anderson@intel.com>
@lucasphillips lucasphillips mentioned this issue Mar 7, 2025
Merged
@mkorbel1 mkorbel1 linked a pull request Mar 7, 2025 that will close this issue
Floating Point Square Root Module with Variable Odd Mantissa and No Rounding #188
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucasphillips lucasphillips

Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Floating Point Square Root Module with Variable Odd Mantissa and No Rounding lucasphillips/rohd-hcl
2 participants
@lucasphillips @mkorbel1