Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exceptions from Simulator do not properly end Tests #58

Open
mkorbel1 opened this issue Oct 4, 2024 · 0 comments
Open

Exceptions from Simulator do not properly end Tests #58

mkorbel1 opened this issue Oct 4, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@mkorbel1
Copy link
Contributor

mkorbel1 commented Oct 4, 2024

Describe the bug

If Simulator.run throws an exception, the Test should immediately end (and fail). However, as currently implemented in start, it can cause a hang instead.

Depends on fix from intel/rohd#515

Once the ROHD fix is available, it should be possible to wait for Simulator.simulationEnded and separately start it with unawaited(Simulator.run()), which should allow the exception to throw all the way up instead of hanging quietly.

To Reproduce

Throw an exception in a registerEndOfSimulationAction, then start the test.

Expected behavior

Test fails

Actual behavior

Test hangs

Additional: Dart SDK info

No response

Additional: pubspec.yaml

No response

Additional: Context

No response

@mkorbel1 mkorbel1 added the bug Something isn't working label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant