Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shift gates fail when shift value is a literal #170

Closed
akshay-wankhede opened this issue Sep 28, 2022 · 0 comments · Fixed by #208
Closed

Shift gates fail when shift value is a literal #170

akshay-wankhede opened this issue Sep 28, 2022 · 0 comments · Fixed by #208
Labels
bug Something isn't working

Comments

@akshay-wankhede
Copy link
Contributor

The line below, will result in a runtime error when the value for b (dynamic variable) is passed as a literal.

rohd/lib/src/modules/gates.dart

Line 285 in c9ba07d

_b = Module.unpreferredName('b_' + b.name);

Possible fix:
Instead of 'b.name' use 'bLogic.name'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow constants for modulo and shift operations on Logic mkorbel1/rohd
2 participants
@mkorbel1 @akshay-wankhede