Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SynthBuilder should check modules are already built #246

Closed
mkorbel1 opened this issue Jan 9, 2023 · 2 comments · Fixed by #340
Closed

SynthBuilder should check modules are already built #246

mkorbel1 opened this issue Jan 9, 2023 · 2 comments · Fixed by #340
Assignees
@quekyj
Labels
bug Something isn't working

Comments

@mkorbel1
Copy link
Contributor

mkorbel1 commented Jan 9, 2023

Describe the bug

It's possible to generate outputs using a Synthesizer and SynthBuilder rather than through Module.generateSynth. However, the SynthBuilder does not check that Module.build is called, only generateSynth does. This can produce unexpected outputs (e.g. SystemVerilog with no submodules) without any helpful error message indicating why.

To Reproduce

Use SynthBuilder to generate output verilog without calling build on the Module.

Expected behavior

ModuleNotBuiltException is thrown

Actual behavior

Silent incorrect results

Additional: Dart SDK info

No response

Additional: pubspec.yaml

No response

Additional: Context

No response
@mkorbel1 mkorbel1 added the bug Something isn't working label Jan 9, 2023
@quekyj
Copy link
Contributor

quekyj commented Mar 27, 2023

@mkorbel1 Let me look into this.

@mkorbel1
Copy link
Contributor Author

Sure, thanks!

@quekyj quekyj mentioned this issue Apr 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@quekyj quekyj

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Issue 246] SynthBuilder should check for Module.build() quekyj/rohd
2 participants
@mkorbel1 @quekyj