Skip to content
This repository has been archived by the owner on Nov 8, 2022. It is now read-only.

Potential thread safety issue during initialisation of plugin #16

Closed
obourdon opened this issue Sep 21, 2016 · 2 comments
Closed

Potential thread safety issue during initialisation of plugin #16

obourdon opened this issue Sep 21, 2016 · 2 comments

Comments

@obourdon
Copy link

Snap version (use snapctl -v): ANY
Environment:

  • Cloud provider or hardware configuration: ANY
  • OS (e.g. from /etc/os-release): Linux (Debian 8.0 & Ubuntu 1[46].04 amd64)

Potential thread safety issue during initialisation of plugin

Looking at a PR which has been integrated earlier for the SMART plugin, and more specifically at commit bf7c332 and commit dada577 which have been added to comply with @lmroz comment r73497782, the same code should be integrated into interface collector plugin

@katarzyna-z
Copy link
Contributor

@obourdon Thank you for reporting this issue. It should be carefully investigated.

@IzabellaRaulin
Copy link
Contributor

This plugin uses sticky routing strategy, so concurrency count is set to 1, what means there is no possibilities to use a single plugin instance by two tasks.

There is also an issue to provide Init() once function behavior to plugin lib to make easier manage initialization in plugins which require that - 👉 intelsdi-x/snap-plugin-lib-go#79

Based on above, I will close this issue. Of course, please do not hesitate to re-open if you notice that this issue is still valid in some circumstances. Thank You.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants