Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

Return proper HTTP errors #4

Closed
5 tasks done
albertpastrana opened this issue Mar 12, 2019 · 4 comments · Fixed by #31
Closed
5 tasks done

Return proper HTTP errors #4

albertpastrana opened this issue Mar 12, 2019 · 4 comments · Fixed by #31
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@albertpastrana
Copy link
Member

albertpastrana commented Mar 12, 2019

As an API client
I want the service to return proper http errors
so that I know if I have to fix my request or it's that the service is down

Acceptance Criteria
This just applies to the code we have for the POC (more may need to be added as the project evolves, to be defined in each new feature/change):

  • Repository not found: 404
  • File not found: 404
  • Reference not found: 404
  • No repo/file/reference param: 400
  • Other errors: 500
@albertpastrana albertpastrana added enhancement New feature or request good first issue Good for newcomers labels Mar 12, 2019
@kittsville kittsville self-assigned this Mar 28, 2019
@kittsville
Copy link
Contributor

kittsville commented Apr 5, 2019

As per #24 reference will become an optional param, so we'll only need to return 400 for repo/file missing. Although if ${repo} was missing it'd just be localhost:7791/repo/, which could return a list of the available repos?

@nathankleyn
Copy link
Contributor

nathankleyn commented Apr 18, 2019

@kittsville I converted the above list into a task list for you and moved it into the ticket description to make it a little easier to track — this causes it to show like subtasks elsewhere in the UI. 👍

See https://help.github.com/en/articles/about-task-lists for more info.

Screenshot 2019-04-18 at 14 39 33

@nathankleyn
Copy link
Contributor

Re-opening for now as there's still two errors to do above (it got closed automatically by #31).

@kittsville
Copy link
Contributor

IIRC those are already done, as they were implemented in #31

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants