Change type of max_gas to i64, and remove two clones.

[yihuang]

I'm not sure about the specification of max_gas, but the default genesis.conf generated by tendermint has max_gas set to -1, so.

[liamsi]

@yihuang do you mind redoing this with signed commits?

[yihuang]

@yihuang do you mind redoing this with signed commits?

Done.

[liamsi]

LGTM. Strangely only one of two commits show up as signed:

Can't merge to master if not all commits are signed.

[yihuang]

Sorry for the delay, it's done now. @liamsi

[liamsi]

Thanks! Good work as always 👍 (and sorry for the delay on my side, too)

[liamsi]

Will try again later ...

I'm more and more convinced we should stop requiring all commits to be signed :-/ It's causing some difficulties and provides little security.

[liamsi]

Tried several times to merge this. I suspect this PR can’t be merged (although all / the two commits are signed) because master moved forward one commit in the meantime; and github can’t secretly rebase and retry but the contributor has to rebase before this can be merged. At least that's my only explanation. Maybe it's just some github hickup. Will try again tomorrow.

[tarcieri]

github can’t secretly rebase and retry

It can, but it's been explicitly disabled...

[liamsi]

It can, but it's been explicitly disabled...

Yeah, I meant it can't anymore now that "squash and merge" is the only enabled option. Maybe we can re-enable the rebase option even if we agree on a policy of only squash merging (and let at least github do the rebasing implicitly as before).

[yihuang]

I just rebased to the new master.

[liamsi]

Still LGTM 👍

[ebuchman]

Sorry for the trouble folks - disabled the signed commits requirement. Thanks @yihuang