Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse validators field in genesis api #65

Merged
merged 1 commit into from
Nov 28, 2019

Conversation

yihuang
Copy link
Contributor

@yihuang yihuang commented Nov 13, 2019

genesis endpoint response has a validators field, which is similar to the one from validators endpoint, we can re-use the data type for this, only difference is the field name of voting_power becomes power.

@@ -20,6 +20,7 @@
]
}
},
"validators": [],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind adding in a validator here? You copy&paste the from genesis example in https://docs.tendermint.com/master/rpc/#/Info/genesis

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Member

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@liamsi liamsi merged commit 9adb13d into informalsystems:master Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants