Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test storage key decoding or ask Parity for advice #452

Open
daniel-savu opened this issue Feb 21, 2023 · 1 comment
Open

Test storage key decoding or ask Parity for advice #452

daniel-savu opened this issue Feb 21, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@daniel-savu
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The decoding of storage keys used in the clients will break if the hasher used by their containing map changes (e.g. switching to BLAKE_2_128 from TWOX_64). That is because the decoding uses hardcoded assumptions, in spite of the hasher info being available in the metadata.

Describe the solution you'd like
Either add tests so the pipeline breaks on such a change, or ask Parity if there is an automatic way of using metadata information to decode storage keys.

@daniel-savu daniel-savu added the enhancement New feature or request label Feb 21, 2023
@gregdhill
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

2 participants