Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate errors in the on_slash hook of loans #1065

Open
daniel-savu opened this issue May 23, 2023 · 0 comments
Open

Propagate errors in the on_slash hook of loans #1065

daniel-savu opened this issue May 23, 2023 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@daniel-savu
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Due to the slash signature in FRAME, the orml-traits OnSlash hook is also not allowed to return a Result.

Describe the solution you'd like
The opened issue on the substrate repo seems to be slowly making progress, but it may be desirable to speed this up by implementing this ourselves upstream. Once that is done, the on_slash function in orml-traits should return a DispatchResult and the loans code should propagate errors instead of logging them.

@daniel-savu daniel-savu added the enhancement New feature or request label May 23, 2023
@daniel-savu daniel-savu added this to the Lend / Borrow milestone May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

1 participant