feat: allow cancelled replace requests to be executed #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
gregdhill
force-pushed
the
feat/recovery-replace
branch
from
026eb86 to
f2c2247
Compare
sander2
requested changes
Apr 20, 2022
There was a problem hiding this comment.
Can you add an integration test for executing a cancelled replace where there was a non-zero additional-collateral amount supplied by the new vault? I think that might be not handled correctly with this pr.
You can use this function with a non-zero amount: https://github.com/interlay/interbtc/blob/master/standalone/runtime/tests/mock/replace_testing_utils.rs#L61
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
sander2
reviewed
Apr 20, 2022
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
sander2
approved these changes
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gregory Hill gregorydhill@outlook.com