Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Escrow RPCs #689

Merged
merged 2 commits into from
Aug 4, 2022
Merged

feat: Escrow RPCs #689

merged 2 commits into from
Aug 4, 2022

Conversation

theodorebugnet
Copy link
Contributor

@theodorebugnet theodorebugnet commented Aug 1, 2022

Adds RPCs for the escrow crate, to avoid functionality being re-implemented in the lib.

@theodorebugnet theodorebugnet force-pushed the theo/escrow-rpc branch 2 times, most recently from 957af3d to cff0cfb Compare August 2, 2022 16:24
@theodorebugnet theodorebugnet marked this pull request as ready for review August 2, 2022 18:35
@theodorebugnet theodorebugnet changed the title WIP Escrow RPCs Aug 3, 2022
Copy link
Member

@gregdhill gregdhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only blocking comment is the inclusion of total_locked(), otherwise LGTM!

crates/escrow/rpc/src/lib.rs Show resolved Hide resolved
crates/escrow/rpc/src/lib.rs Show resolved Hide resolved
crates/escrow/src/lib.rs Outdated Show resolved Hide resolved
@sander2 sander2 changed the title Escrow RPCs feat: Escrow RPCs Aug 4, 2022
@sander2 sander2 merged commit ce16792 into master Aug 4, 2022
@theodorebugnet theodorebugnet deleted the theo/escrow-rpc branch August 4, 2022 10:28
@gregdhill gregdhill mentioned this pull request Aug 4, 2022
@sander2 sander2 added this to the Release 1.19 milestone Sep 7, 2022
@gregdhill gregdhill mentioned this pull request Jan 18, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants