Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling of invalid stream packets #704

Open
koivunej opened this issue Apr 6, 2021 · 0 comments
Open

Handling of invalid stream packets #704

koivunej opened this issue Apr 6, 2021 · 0 comments

Comments

@koivunej
Copy link
Collaborator

koivunej commented Apr 6, 2021

#703 silenced two loggings which were output for decryption failures and for any parsing failure (including decryption failure). As before #703, the behaviour on invalid but successfully decrypted prepares was not changed, so they are still forwarded to next handlers.

Succeeding in decrypting the packet but failing to parse it should most lead to an immediate rejection. This should be confirmed from the stream RFC and fixed.

Marking this as good-first-issue as this code isn't too involved, and there are examples of rejection in the interledger-stream already. Also mentoring is available by pinging me or someone else who has been recently active.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant