Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for Remix future changes #1464

Closed
raducristianpopa opened this issue May 22, 2023 · 0 comments · Fixed by #2349
Closed

Prepare for Remix future changes #1464

raducristianpopa opened this issue May 22, 2023 · 0 comments · Fixed by #2349
Assignees
Labels
discussions: general Convert to a general discussion pkg: frontend Changes in the frontend package. type: enhancement New feature or request
Milestone

Comments

@raducristianpopa
Copy link
Member

raducristianpopa commented May 22, 2023

⚠️ REMIX FUTURE CHANGE: The behaviors of 'CatchBoundary' and 'ErrorBoundary' are changing in v2. You can prepare for this change at your convenience with the 'v2_errorBoundary' future flag. For instructions on making this change see https://remix.run/docs/en/v1.15.0/pages/v2#catchboundary-and-errorboundary
⚠️ REMIX FUTURE CHANGE: APIs that provide 'formMethod' will be changing in v2. All values will be uppercase (GET, POST, etc.) instead of lowercase (get, post, etc.) You can prepare for this change at your convenience with the 'v2_normalizeFormMethod' future flag. For instructions on making this change see https://remix.run/docs/en/v1.15.0/pages/v2#formMethod
⚠️ REMIX FUTURE CHANGE: The route 'meta' export signature is changing in v2. You can prepare for this change at your convenience with the 'v2_meta' future flag. For instructions on making this change see https://remix.run/docs/en/v1.15.0/pages/v2#meta
⚠️ REMIX FUTURE CHANGE: The 'serverModuleFormat' config default option will be changing in v2 from 'cjs' to 'esm'. You can prepare for this change by explicitly specifying 'serverModuleFormat: 'cjs''. For instructions on making this change see https://remix.run/docs/en/v1.16.0/pages/v2#servermoduleformat
⚠️ REMIX FUTURE CHANGE: The route file convention is changing in v2. You can prepare for this change at your convenience with the 'v2_routeConvention' future flag. For instructions on making this change see https://remix.run/docs/en/v1.15.0/pages/v2#file-system-route-convention

We should also add a typecheck command to the project, and update the Github Action to call it.
Typescript compilation should pass since v2: remix-run/remix#4371

@raducristianpopa raducristianpopa added type: enhancement New feature or request discussions: general Convert to a general discussion pkg: frontend Changes in the frontend package. labels May 22, 2023
@mkurapov mkurapov added this to the Tech Debt milestone Jun 20, 2023
@mkurapov mkurapov added this to Rafiki Jun 21, 2023
@mkurapov mkurapov moved this to Backlog in Rafiki Jun 21, 2023
@BlairCurrey BlairCurrey self-assigned this Jan 18, 2024
@BlairCurrey BlairCurrey moved this from Backlog to Todo in Rafiki Jan 18, 2024
@BlairCurrey BlairCurrey moved this from Todo to In Progress in Rafiki Jan 22, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Rafiki Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussions: general Convert to a general discussion pkg: frontend Changes in the frontend package. type: enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants