Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement local pay method #2855

Closed
Tracked by #2834
mkurapov opened this issue Aug 9, 2024 · 0 comments · Fixed by #2857
Closed
Tracked by #2834

Implement local pay method #2855

mkurapov opened this issue Aug 9, 2024 · 0 comments · Fixed by #2857
Assignees

Comments

@mkurapov
Copy link
Contributor

mkurapov commented Aug 9, 2024

Context

To actually make the local payments happen, we will need to implement the pay method of the new local payment method handling service.

This method will call the accountingService.createTransfer function which will make a transfer between the outgoing payment (the source account) and the incoming payment (destination account) using the amounts from the original quote. This can be a instantly-posted transfer, meaning, we don't need to create a pending transfer with a timeout, we can just make the accounting transfer instantly.

@github-project-automation github-project-automation bot moved this to Backlog in Rafiki Aug 9, 2024
@mkurapov mkurapov changed the title Implement the local pay method, which calls createTransfer between the outgoing payment and the incoming payment using the amounts from the original quote Implement local pay method Aug 9, 2024
@mkurapov mkurapov moved this from Backlog to Todo in Rafiki Aug 9, 2024
@BlairCurrey BlairCurrey self-assigned this Aug 9, 2024
@BlairCurrey BlairCurrey moved this from Todo to In Progress in Rafiki Aug 9, 2024
@github-project-automation github-project-automation bot moved this from Ready for Review to Done in Rafiki Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants