Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the createQuote mutation response type #2856

Closed
Tracked by #2834
mkurapov opened this issue Aug 9, 2024 · 0 comments · Fixed by #2858
Closed
Tracked by #2834

Update the createQuote mutation response type #2856

mkurapov opened this issue Aug 9, 2024 · 0 comments · Fixed by #2858
Assignees

Comments

@mkurapov
Copy link
Contributor

mkurapov commented Aug 9, 2024

Context

In the CreateQuote method, we are returning a few ILP-specific fields: maxPacketAmount minExchangeRate lowEstimatedExchangeRate highEstimatedExchangeRate. These are used internally only, and unlikely to be useful to any callers of the Admin APIs, so they can be removed from the resulting schema. They become especially unnecessary with the introduction of local payments.

However, it would be useful to start exposing estimatedExchangeRate in the response object, as it can give integrators an easy way to display quote details to their end users.

@github-project-automation github-project-automation bot moved this to Backlog in Rafiki Aug 9, 2024
@mkurapov mkurapov changed the title Removing the ILP-specific GraphQL fields from the CreateQuote method: maxPacketAmount minExchangeRate lowEstimatedExchangeRate highEstimatedExchangeRate, but add estimatedExchangeRate Update the createQuote mutation response type Aug 9, 2024
@mkurapov mkurapov moved this from Backlog to Todo in Rafiki Aug 9, 2024
@golobitch golobitch self-assigned this Aug 10, 2024
@github-project-automation github-project-automation bot moved this from Ready for Review to Done in Rafiki Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants