Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default limit for accountingTransfers backend API #3003

Open
3 tasks
mkurapov opened this issue Sep 24, 2024 · 2 comments · May be fixed by #3115
Open
3 tasks

Set default limit for accountingTransfers backend API #3003

mkurapov opened this issue Sep 24, 2024 · 2 comments · May be fixed by #3115
Assignees
Labels

Comments

@mkurapov
Copy link
Contributor

mkurapov commented Sep 24, 2024

Context

Currently, in our accountingTransfers query in the backend API, because we do not yet have pagination, we only allow providing a limit value to how many transfers are returned. For this query, when using Tigerbeetle, we have a limit set to 100_000. This is also what is mentioned in the description.

We should set a smaller default limit for both accounting services, (20?) and make sure to update the description in the GraphQL API to be accounting service agnostic.

Todos

  • Update limit in both of the accounting services to be 20 for fetching transfers
  • Update GraphQL API description
  • Tag writer @brad-dow to take a look at the description change
@nawinsharma
Copy link

@mkurapov can you assign me?

@sabineschaller
Copy link
Member

@NawinKumarSharma It's yours! 🙂

@nawinsharma nawinsharma removed their assignment Oct 14, 2024
@oana-lolea oana-lolea moved this from Todo to In Progress in Rafiki Nov 20, 2024
@oana-lolea oana-lolea linked a pull request Nov 21, 2024 that will close this issue
6 tasks
@oana-lolea oana-lolea moved this from In Progress to Ready for Review in Rafiki Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Ready for Review
Development

Successfully merging a pull request may close this issue.

4 participants