Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional fields to AccountingTransfers Admin API #3106

Open
1 task
mkurapov opened this issue Nov 19, 2024 · 0 comments
Open
1 task

Add additional fields to AccountingTransfers Admin API #3106

mkurapov opened this issue Nov 19, 2024 · 0 comments
Assignees

Comments

@mkurapov
Copy link
Contributor

mkurapov commented Nov 19, 2024

Context

In the accountingTransfers Admin Query API, we can fetch all of the underlying accounting movements for a particular account. For example, for an outgoing payment, it would look something like this:

{
  "data": {
    "accountingTransfers": {
      "debits": [
        {
          "id": "8a6e9072-08d1-4495-887b-a1bc0bbccdc6",
          "debitAccountId": "92a92408-1bb2-4300-8b3c-ebb71d6c9032",
          "creditAccountId": "8d0f1efb-b763-4a17-883a-1d6f920202d9",
          "amount": "550",
          "transferType": "TRANSFER",
          "ledger": 1,
          "createdAt": "2024-11-19T14:09:15.664Z"
        },
        {
          "id": "3011637c-9799-4f32-98ce-a6a5f4cb1a85",
          "debitAccountId": "92a92408-1bb2-4300-8b3c-ebb71d6c9032",
          "creditAccountId": "8d0f1efb-b763-4a17-883a-1d6f920202d9",
          "amount": "550",
          "transferType": "TRANSFER",
          "ledger": 1,
          "createdAt": "2024-11-19T14:09:15.691Z"
        }
      ],
      "credits": [
        {
          "id": "e27878d7-03b3-466b-b6c1-a93b37b5020c",
          "debitAccountId": "00000000-0000-0000-0000-000000000001",
          "creditAccountId": "92a92408-1bb2-4300-8b3c-ebb71d6c9032",
          "amount": "668",
          "transferType": "DEPOSIT",
          "ledger": 1,
          "createdAt": "2024-11-19T14:09:15.426Z"
        }
      ]
    }
  }
}

where we funded the payment for 668, and made a transfer for 550. One of these transfers, however, is an expired, pending transfer that we made before we sent ILP packets to a separate Rafiki, but it isn't clear in the API. We should add state and expiresAt to the API result.

Todos

  • Add state and expiresAt to the type AccountingTransfer in the Admin API schema
@github-project-automation github-project-automation bot moved this to Backlog in Rafiki Nov 19, 2024
@oana-lolea oana-lolea moved this from Todo to In Progress in Rafiki Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

No branches or pull requests

2 participants