Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simplify OpenPaymentsService #713

Open
sidvishnoi opened this issue Nov 14, 2024 · 0 comments
Open

refactor: simplify OpenPaymentsService #713

sidvishnoi opened this issue Nov 14, 2024 · 0 comments
Labels
area: background Improvements or additions to extension background script good first issue Good for newcomers refactor

Comments

@sidvishnoi
Copy link
Member

OpenPaymentsService has grown a lot (1000+ lines) as we kept adding new things to this service directly. For a cleanup, it might be worth separating the connect wallet parts to a separate service. I think OutgoingPaymentGrantService might be a good name, as we use same grant part in connectWallet, addFunds, updateBudget, disconnectWallet and more (open to any better names).

We likely want to keep the token within this OutgoingPaymentGrantService. Might need some care with cyclic dependencies with awilix though.

@sidvishnoi sidvishnoi added good first issue Good for newcomers area: background Improvements or additions to extension background script labels Nov 14, 2024
@sidvishnoi sidvishnoi changed the title Simplify OpenPaymentsService in background Simplify OpenPaymentsService Nov 14, 2024
@sidvishnoi sidvishnoi changed the title Simplify OpenPaymentsService refactor: simplify OpenPaymentsService Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: background Improvements or additions to extension background script good first issue Good for newcomers refactor
Projects
Status: Backlog
Development

No branches or pull requests

1 participant