Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify padding for base64URL encoded values #44

Open
gip opened this issue Jul 14, 2016 · 1 comment
Open

Specify padding for base64URL encoded values #44

gip opened this issue Jul 14, 2016 · 1 comment

Comments

@gip
Copy link

gip commented Jul 14, 2016

We may want to specify the padding for base64URL encoding in https://interledger.org/five-bells-condition/spec.html.

From rfc4648 :

In some circumstances, the use of padding ("=") in base-encoded data
   is not required or used.  In the general case, when assumptions about
   the size of transported data cannot be made, padding is required to
   yield correct decoded data.

   Implementations MUST include appropriate pad characters at the end of
   encoded data unless the specification referring to this document
   explicitly states otherwise.

It looks like some implementation (like the one in this directory) drops padding. Implementations in other languages may not (for instance in Java and Haskell), creating inconsistencies. Comparing conditions becomes more complex in case of optional padding.

@justmoon
Copy link
Contributor

justmoon commented Aug 1, 2016

Good point! Our decision is to use no padding. If padding appears, the condition should be considered invalid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants