Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement plugin.sendMoney #11

Closed
michielbdejong opened this issue Jan 31, 2018 · 1 comment
Closed

Implement plugin.sendMoney #11

michielbdejong opened this issue Jan 31, 2018 · 1 comment

Comments

@michielbdejong
Copy link
Contributor

It seems that https://github.com/interledgerjs/ilp-plugin-xrp-asym-server/blob/master/index.js#L498 is used instead of https://github.com/interledgerjs/ilp-plugin-xrp-asym-server/blob/master/index.js#L520-L524?

Obviously, since this plugin exposes only one LPI, but in reality represents possibly many connected peers, it's not possible to know who to send money to when plugin.sendMoney is called. The same problem exists for plugin.sendData, which this plugin inherits from ilp-plugin-mini-accounts, but there it's solved with deep packet inspection. That same trick cannot be used here.

Maybe we should just stop pursuing the concept of exposing only one LPI? Otherwise, maybe we should change the LPI to support server plugins?

@sharafian
Copy link

Given the current LPI, where a server plugin is behaving as a connector, this plugin is performing the correct behavior. Can we close this and continue discussion of the issue of whether the LPI should change in RFCs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants