Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct Read links in Search Inside results when multiple files or filename-vs.-id disparity #339

Closed
bfalling opened this issue Oct 10, 2016 · 3 comments
Labels
Lead: @mekarpeles Issues overseen by Mek (Staff: Program Lead) [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Theme: Identifiers Issues related to ISBN's or other identifiers in metadata. [managed] Type: Bug Something isn't working. [managed]

Comments

@bfalling
Copy link
Collaborator

bfalling commented Oct 10, 2016

In the Search Inside search results, the Read links need to be changed to handle cases where the image stack filename is different from the Archive.org ID (as often happens due to characters like spaces in the filename), and where the search result is for one file in an Archive.org item containing multiple files.

In both cases, the solution is to construct links that incorporate the filename, as opposed to only the Archive.org ID, when necessary. The filename can be parsed via the Metadata API.

e.g.
Metadata API call:
https://archive.org/metadata/savefanfiction-10399417-It_was_worth_it-kettleowl/files

Link to BookReader with Search Inside:
https://archive.org/stream/savefanfiction-10399417-It_was_worth_it-kettleowl/It%20was%20worth%20it-ffnet_10399417#search/Friendship

FYI: Incorrect link that redirects to Details page:
http://archive.org/stream/savefanfiction-10399417-It_was_worth_it-kettleowl#search/Friendship

@xayhewalo xayhewalo added Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] State: Backlogged Theme: Identifiers Issues related to ISBN's or other identifiers in metadata. [managed] Type: Bug Something isn't working. [managed] labels Oct 21, 2019
@xayhewalo
Copy link
Collaborator

@hornc This looks like an issue you'd tackle. Are you willing to be assignee? Note: being assignee doesn't necessarily mean you are the one doing the work for the issue but responsible for collecting information needed to devise a solution. From the wiki:

At submission and prior to triage, the assigned owner is not necessarily the person who will fix the issue (it is not necessarily even established, at that point, if or when the issue will be fixed at all), but rather they are the person who will do as much or as little as needed to handle the issue (asking questions, soliciting input, establishing and updating the priority, checking if it is a duplicate, etc).

Once an issue is labeled State: Work In Progress, the owner is the individual doing the work, or leading/coordinating the group that is doing the work.

I've added labels per the issue's context. Let me know if you agree or disagree.

@xayhewalo xayhewalo added the Priority: 3 Issues that we can consider at our leisure. [managed] label Nov 26, 2019
@mekarpeles mekarpeles removed the Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] label Apr 20, 2020
@cdrini cdrini added Lead: @mekarpeles Issues overseen by Mek (Staff: Program Lead) [managed] and removed Needs: Lead labels Apr 11, 2022
@cdrini
Copy link
Collaborator

cdrini commented Apr 11, 2022

This needs to be verified if it's still an issue. It's only been 8 years :)

@RayBB
Copy link
Collaborator

RayBB commented Oct 7, 2023

Moved to internetarchive/bookreader#1254

@RayBB RayBB closed this as completed Oct 7, 2023
@RayBB RayBB closed this as not planned Won't fix, can't repro, duplicate, stale Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Lead: @mekarpeles Issues overseen by Mek (Staff: Program Lead) [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Theme: Identifiers Issues related to ISBN's or other identifiers in metadata. [managed] Type: Bug Something isn't working. [managed]
Projects
None yet
Development

No branches or pull requests

5 participants