-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct Read links in Search Inside results when multiple files or filename-vs.-id disparity #339
Comments
@hornc This looks like an issue you'd tackle. Are you willing to be assignee? Note: being assignee doesn't necessarily mean you are the one doing the work for the issue but responsible for collecting information needed to devise a solution. From the wiki:
I've added labels per the issue's context. Let me know if you agree or disagree. |
This needs to be verified if it's still an issue. It's only been 8 years :) |
Moved to internetarchive/bookreader#1254 |
In the Search Inside search results, the Read links need to be changed to handle cases where the image stack filename is different from the Archive.org ID (as often happens due to characters like spaces in the filename), and where the search result is for one file in an Archive.org item containing multiple files.
In both cases, the solution is to construct links that incorporate the filename, as opposed to only the Archive.org ID, when necessary. The filename can be parsed via the Metadata API.
e.g.
Metadata API call:
https://archive.org/metadata/savefanfiction-10399417-It_was_worth_it-kettleowl/files
Link to BookReader with Search Inside:
https://archive.org/stream/savefanfiction-10399417-It_was_worth_it-kettleowl/It%20was%20worth%20it-ffnet_10399417#search/Friendship
FYI: Incorrect link that redirects to Details page:
http://archive.org/stream/savefanfiction-10399417-It_was_worth_it-kettleowl#search/Friendship
The text was updated successfully, but these errors were encountered: