Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker image to docker hub #3615

Closed
cdrini opened this issue Jul 22, 2020 · 2 comments · Fixed by #3631
Closed

Add docker image to docker hub #3615

cdrini opened this issue Jul 22, 2020 · 2 comments · Fixed by #3631
Assignees
Labels
Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Module: Docker Issues related to the configuration or use of Docker. [managed] Priority: 2 Important, as time permits. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]

Comments

@cdrini
Copy link
Collaborator

cdrini commented Jul 22, 2020

I'm tired of having to debug docker build issues. If we upload these to docker hub, then all developers need to run to get their environment up is docker-compose up -d; and that will download all the correct things, no building necessary. Docker hub also has options to auto-rebuild the image when master is modified, so it'll always be up-to-date. Then the only people who need to build will be folks specifically making mods to OS-level dependencies.

Stakeholders

@cclauss

@cdrini cdrini added Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed] Module: Docker Issues related to the configuration or use of Docker. [managed] Priority: 2 Important, as time permits. [managed] Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] labels Jul 22, 2020
@cdrini cdrini self-assigned this Jul 22, 2020
@cdrini
Copy link
Collaborator Author

cdrini commented Jul 22, 2020

I tried this, but was getting issues with git submodules https://hub.docker.com/repository/registry-1.docker.io/cdrini/openlibrary-base/builds/749b2591-b4de-450c-934b-aea37e532366

Step 32/34 : RUN make
---> Running in d759b10b38a8
git submodule init
git submodule sync
Synchronizing submodule url for 'vendor/acs4_py'
fatal: Not a git repository: /src/b5zzm7ft4camr3dmqyebyt6/.git/modules/vendor/acs4_py
fatal: Not a git repository: /src/b5zzm7ft4camr3dmqyebyt6/.git/modules/vendor/acs4_py
fatal: Not a git repository: /src/b5zzm7ft4camr3dmqyebyt6/.git/modules/vendor/acs4_py
Synchronizing submodule url for 'vendor/infogami'
fatal: Not a git repository: /src/b5zzm7ft4camr3dmqyebyt6/.git/modules/vendor/infogami
fatal: Not a git repository: /src/b5zzm7ft4camr3dmqyebyt6/.git/modules/vendor/infogami
fatal: Not a git repository: /src/b5zzm7ft4camr3dmqyebyt6/.git/modules/vendor/infogami
Synchronizing submodule url for 'vendor/js/wmd'
fatal: Not a git repository: /src/b5zzm7ft4camr3dmqyebyt6/.git/modules/vendor/js/wmd
fatal: Not a git repository: /src/b5zzm7ft4camr3dmqyebyt6/.git/modules/vendor/js/wmd
fatal: Not a git repository: /src/b5zzm7ft4camr3dmqyebyt6/.git/modules/vendor/js/wmd
git submodule update
fatal: Not a git repository: /src/b5zzm7ft4camr3dmqyebyt6/.git/modules/vendor/acs4_py
Unable to find current revision in submodule path 'vendor/acs4_py'
Makefile:43: recipe for target 'git' failed
make: *** [git] Error 1
Removing intermediate container d759b10b38a8

@aasifkhan7
Copy link
Contributor

@cdrini I got the same error.

�[91mfatal: Not a git repository: /src/bfmmyelvcgvddkeptyoykzd/.git/modules/vendor/acs4_py
�[0m
�[91mfatal: Not a git repository: /src/bfmmyelvcgvddkeptyoykzd/.git/modules/vendor/acs4_py
�[0m
�[91mfatal: Not a git repository: /src/bfmmyelvcgvddkeptyoykzd/.git/modules/vendor/acs4_py
�[0m

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Module: Docker Issues related to the configuration or use of Docker. [managed] Priority: 2 Important, as time permits. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants