Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "Not In Library" button with "Check local libraries" #6525

Closed
mekarpeles opened this issue May 9, 2022 · 17 comments
Closed

Replace "Not In Library" button with "Check local libraries" #6525

mekarpeles opened this issue May 9, 2022 · 17 comments
Assignees
Labels
Affects: Partners Lead: @mekarpeles Issues overseen by Mek (Staff: Program Lead) [managed] Module: Borrowing / Lending Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Needs: Community Discussion This issue is to be brought up in the next community call. [managed] Priority: 2 Important, as time permits. [managed]

Comments

@mekarpeles
Copy link
Member

mekarpeles commented May 9, 2022

Related to #5831

Problem

Patrons get confused when they see a button that says "Not in library". It's a dead end. Instead, we should give them a default action of searching for an Open Library book within their local libraries using Worldcat or LibraryLink.

Describe the problem that you'd like solved

Replace Not in library button:
openlibrary org_search_q=the+best+thing mode=everything

With Check local libraries:
openlibrary org_search_q=the+best+thing mode=everything (3)

Proposal & Constraints

Additional context

Code:
https://github.com/internetarchive/openlibrary/blob/master/openlibrary/macros/LoanStatus.html#L137-L140

Stakeholders

@jimchamp @cdrini @seabelis @JeffKaplan @bfalling

@mekarpeles mekarpeles added Priority: 1 Do this week, receiving emails, time sensitive, . [managed] Module: Borrowing / Lending Affects: Partners Lead: @mekarpeles Issues overseen by Mek (Staff: Program Lead) [managed] Good First Issue Easy issue. Good for newcomers. [managed] Needs: Help Issues, typically substantial ones, that need a dedicated developer to take them on. [managed] labels May 9, 2022
@mekarpeles
Copy link
Member Author

For now, clicking btn will go to Worldcat, eventually we may wish to explore integrations which show library availability from within the context of Open Library and the other valuable info we're able to show on the book page.

@mekarpeles mekarpeles added this to the Active Sprint milestone May 9, 2022
@mekarpeles mekarpeles self-assigned this May 9, 2022
@tuminzee
Copy link
Collaborator

@mekarpeles I see that you have self-assigned this issue. Would like me to work on this one?

@mekarpeles
Copy link
Member Author

This one is a bit tricky and I'm almost done :)

@mekarpeles mekarpeles added Priority: 2 Important, as time permits. [managed] and removed Priority: 1 Do this week, receiving emails, time sensitive, . [managed] labels Jun 6, 2022
@cdrini cdrini modified the milestones: Sprint 2022-05, Active Sprint Jun 13, 2022
@mekarpeles
Copy link
Member Author

mekarpeles commented Jun 20, 2022

Prototype: Create a modal similar to the share modal which has tabs & iframe for checking Library.Link & Worldcat availability.

@mekarpeles mekarpeles added the Needs: Community Discussion This issue is to be brought up in the next community call. [managed] label Sep 19, 2022
@mekarpeles mekarpeles modified the milestones: Active Sprint, Next Sprint Oct 4, 2022
@ThisIsRahmat
Copy link

ThisIsRahmat commented Jan 9, 2023

Hi @mekarpeles I want to contribute to this issue but you mentioned that you're working on it but there is no update since October. Is it okay for me to take on the issue?

I am a open source beginner so I don't know what the norm is.

@tuminzee
Copy link
Collaborator

hello @ThisIsRahmat I will list down few resources which can help you understand the codebase and flow better
Readme.md
https://github.com/internetarchive/openlibrary/blob/master/CONTRIBUTING.md

I hope this helps.

@mekarpeles mekarpeles modified the milestones: Next Sprint, 2023 Jan 26, 2023
@ayushdhiman-py
Copy link

hey i want to work on this issue please assign me this issue

@mekarpeles
Copy link
Member Author

The current state of this issue is that, instead of "Not In Library" the button should say: Locate using the primary color button and pop up a modal with worldcat results

@tuminzee
Copy link
Collaborator

tuminzee commented Jun 1, 2024

@mekarpeles can I work on this issue?

@github-actions github-actions bot added the Needs: Response Issues which require feedback from lead label Jun 2, 2024
@mekarpeles
Copy link
Member Author

@tuminzee this one may be complicated as some books don't have ISBNs and there's still discussion about what type of experience should occur when the button is clicked and so I've assigned it to myself, sorry! ❤️

@mekarpeles mekarpeles removed the Needs: Response Issues which require feedback from lead label Jun 10, 2024
@tuminzee
Copy link
Collaborator

@mekarpeles that's cool I'll find some
other issue 🕺🕺🕺

@github-actions github-actions bot added the Needs: Response Issues which require feedback from lead label Jun 11, 2024
@mekarpeles mekarpeles removed the Needs: Response Issues which require feedback from lead label Jun 28, 2024
@mekarpeles
Copy link
Member Author

@SivanC let's achieve this in our PR for #5831

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Affects: Partners Lead: @mekarpeles Issues overseen by Mek (Staff: Program Lead) [managed] Module: Borrowing / Lending Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Needs: Community Discussion This issue is to be brought up in the next community call. [managed] Priority: 2 Important, as time permits. [managed]
Projects
None yet
9 participants