Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Link Tracks to Download Hrefs #9782

Open
7 tasks done
merwhite11 opened this issue Aug 20, 2024 · 1 comment · May be fixed by #9837
Open
7 tasks done

Add Link Tracks to Download Hrefs #9782

merwhite11 opened this issue Aug 20, 2024 · 1 comment · May be fixed by #9837
Assignees
@merwhite11
Labels
Lead: @mekarpeles Issues overseen by Mek (Staff: Program Lead) [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]

Comments

@merwhite11
Copy link
Collaborator

merwhite11 commented Aug 20, 2024 •
edited
Loading

Description, Patron Story

Add data-ol-link-track="Download" to Download options on books page. Observing click rates in the download option's current state will give a baseline comparison which we can use to the test the efficacy of an additional 'Download' option placement in the Read/Borrow button (@SivanC working on in #5831)

Proposal

Add link tracks to all hrefs in the following files:

Feedback Questions

Decisions

Stakeholders

@cdrini @SivanC
@merwhite11 merwhite11 added Theme: Design Issues related to UI design, branding, etc. [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead Needs: Designs Type: Design Proposal Proposing a design and soliciting feedback + approval Needs: Design Feedback labels Aug 20, 2024
@merwhite11
Copy link
Collaborator Author

@cdrini Hello, here's the issue we talked about today. Could you please assign to me?

Two questions:
Are these are the correct locations to add link tracks to?
How should I name the link track?

@github-actions github-actions bot added the Needs: Response Issues which require feedback from lead label Aug 21, 2024
@mekarpeles mekarpeles added Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed] Lead: @mekarpeles Issues overseen by Mek (Staff: Program Lead) [managed] Priority: 3 Issues that we can consider at our leisure. [managed] and removed Needs: Response Issues which require feedback from lead Theme: Design Issues related to UI design, branding, etc. [managed] Needs: Lead Needs: Designs Type: Design Proposal Proposing a design and soliciting feedback + approval Needs: Design Feedback labels Aug 21, 2024
@merwhite11 merwhite11 linked a pull request Sep 2, 2024 that will close this issue
Open
@jimchamp jimchamp removed the Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@merwhite11 merwhite11

Labels
Lead: @mekarpeles Issues overseen by Mek (Staff: Program Lead) [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added link tracks to all download options merwhite11/openlibrary
3 participants
@mekarpeles @jimchamp @merwhite11