Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide link to all editions in edition table when number of featured editions is equal to total editions #9946

Open
SivanC opened this issue Oct 9, 2024 · 0 comments
Open

Hide link to all editions in edition table when number of featured editions is equal to total editions #9946

SivanC opened this issue Oct 9, 2024 · 0 comments
Labels
Lead: @jimchamp Issues overseen by Jim (Front-end Lead, BookNotes) [managed] Needs: Design Feedback Needs: Designs Priority: 3 Issues that we can consider at our leisure. [managed] Theme: Design Issues related to UI design, branding, etc. [managed] Type: Design Proposal Proposing a design and soliciting feedback + approval

Comments

@SivanC
Copy link
Contributor

SivanC commented Oct 9, 2024

Description, Patron Story

What is the change?

In the edition table, if the number of currently featured editions is equal to the total number of editions, display editions as if ?mode=all was in the URL (i.e. with no text on top about featured and total editions)

Why is it necessary?

Currently, there is a confusing and meaningless distinction between "featured editions" and all editions when all editions of a work are featured. Clicking the link to view all editions does not change the amount of editions or anything else.

Relevant Designs

Current view:
image

With change:
image

Feedback Questions

Decisions

Stakeholders

@mekarpeles - Possibly a good first issue?
@SivanC SivanC added Needs: Design Feedback Needs: Designs Needs: Lead Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Theme: Design Issues related to UI design, branding, etc. [managed] Type: Design Proposal Proposing a design and soliciting feedback + approval labels Oct 9, 2024
@jimchamp jimchamp added Lead: @jimchamp Issues overseen by Jim (Front-end Lead, BookNotes) [managed] Priority: 3 Issues that we can consider at our leisure. [managed] and removed Needs: Lead Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] labels Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Lead: @jimchamp Issues overseen by Jim (Front-end Lead, BookNotes) [managed] Needs: Design Feedback Needs: Designs Priority: 3 Issues that we can consider at our leisure. [managed] Theme: Design Issues related to UI design, branding, etc. [managed] Type: Design Proposal Proposing a design and soliciting feedback + approval
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SivanC @jimchamp