Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Wikipedia link to author page based on Wikidata #9360

Open
RayBB opened this issue May 29, 2024 · 0 comments · May be fixed by #9991
Open

Add Wikipedia link to author page based on Wikidata #9360

RayBB opened this issue May 29, 2024 · 0 comments · May be fixed by #9991
Assignees
Labels
Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] Module: Wikidata Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]

Comments

@RayBB
Copy link
Collaborator

RayBB commented May 29, 2024

Problem

A clear and concise description of what you want to happen

We now have wikidata info pulled in for all authors and want to start using this to improve the author page.

The first thing we should do is add WIkipedia links.
The links should be language aware

  • Show the same language as the user is currently viewing the site in, fall back to english

Expected behaviour / screenshots (ex: Figma design screenshots for UI feature)

Additional Context

This is just the first of the icons we want to display. In the future we will display a few others like Twitter, Instagram, Facebook (to be determined which).

Proposal & Constraints

What is the proposed solution / implementation?

This should be fairly straightforward to get the appropriate sitelink doing something similar to

def get_description(self, language: str = 'en') -> str | None:

For the UI component we need:

  1. An icon for wikipedia (probably one of these) - note phosphor or fluent don't have wikipedia icons
  2. Show the icon on the right sidebar under birth
  3. The icon should have alt text saying wikipedia and linking to the correct page.

Leads

Related files

Stakeholders

Note: Before making a new branch or updating an existing one, please ensure your branch is up to date.

@RayBB RayBB added Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed] Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] Module: Wikidata labels May 29, 2024
@RayBB RayBB self-assigned this May 29, 2024
@RayBB RayBB linked a pull request Nov 5, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] Module: Wikidata Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant