Fix login json SFW #7935
Merged
Fix login json SFW #7935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix json login sfw
mekarpeles
added
Priority: 1
cclauss
reviewed
Jun 6, 2023
Comment on lines
+339
to
+342
| if audit.get('ia_email'): | ||
| ol_account = OpenLibraryAccount.get(email=audit['ia_email']) | ||
| if ol_account and ol_account.get_user().get_safe_mode() == 'yes': | ||
| web.setcookie('sfw', 'yes', expires=expires) |
There was a problem hiding this comment.
Get ia_email once, not twice...
Suggested change
| if audit.get('ia_email'): | |
| ol_account = OpenLibraryAccount.get(email=audit['ia_email']) | |
| if ol_account and ol_account.get_user().get_safe_mode() == 'yes': | |
| web.setcookie('sfw', 'yes', expires=expires) | |
| if ( | |
| ia_email := audit.get('ia_email') | |
| and ol_account := OpenLibraryAccount.get(email=ia_email) | |
| and ol_account.get_user().get_safe_mode() == 'yes' | |
| ): | |
| web.setcookie('sfw', 'yes', expires=expires) |
There was a problem hiding this comment.
I'm pretty sure in this code ia_email will be undefined within the if statement.
There was a problem hiding this comment.
Today I Learned: You need an extra sent of parens around the ia_email := audit.get('ia_email') bit just to make it work properly! Thanks @mekarpeles
cclauss
approved these changes
Jun 6, 2023
jimchamp
removed
the
On testing.openlibrary.org
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a case where for login json endpoint
ol_accountwas being fetched using an empty email as opposed to the email matched by theaudit.