Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make blocked captures available to revisit resolution #65

Open
kngenie opened this issue Jan 25, 2015 · 1 comment
Open

Make blocked captures available to revisit resolution #65

kngenie opened this issue Jan 25, 2015 · 1 comment
Assignees

Comments

@kngenie
Copy link
Member

kngenie commented Jan 25, 2015

Blocked captures are often referred to by later revisit captures, and there's a need for making such blocked captures available only for replaying revisit captures.

Internally known as ARI-3879 and ARI-4034.

@kngenie kngenie self-assigned this Jan 25, 2015
@kngenie
Copy link
Member Author

kngenie commented Jan 25, 2015

Solution introduces new concept soft-blocked captures. While regular exclusion removes capture entirely, soft-block exclusion simply marks capture blocked (indicated by "X" flag in robotflags field).
Soft-blocked captures participate in revisit resolution, but then get removed from final capture search result. This way, soft-blocked captures are made available to revisit replay, without affecting other functionalities, like capture/URL search.

Core functionalities are implemented in commits b0199da .. 0d6dad8 and merged into master in bfe37eb.
Changes so far have been merged to iipc/master as part of 1dbd4f3.

This issue remains open, because there are undesirable side-effects not resolved yet (ex. soft-blocked captures are counted in URL-search results - they should not be).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant