Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL functions depracated #108

Open
webb-ben opened this issue Jun 22, 2023 · 2 comments
Open

SQL functions depracated #108

webb-ben opened this issue Jun 22, 2023 · 2 comments

Comments

@webb-ben
Copy link
Member

It appears that a significant portion of the functions in the Liquibase configuration are deprecated. @dblodgett-usgs @gzt5142 (cc: @EthanGrahn) I would be interested to know if we can prune what is no longer used.

It is my understanding that most of the nhdplus_navigation functions have been superseded with mybatis.

Then it appears that neither nldi-crawler or nldi-crawler-py use any of the nldi_data functions.

@EthanGrahn
Copy link

I believe there are legacy API calls that still rely on a few of the functions. There are also navigation calls that rely on certain plpgsql features (I think it was looping and/or recursive calls) that I wasn't able to migrate to mybatis. I'd be wary of migrating the navigation if mybatis doesn't support it because I found the plpgsql functions to be far faster than trying to work around it in mybatis.

@dblodgett-usgs
Copy link
Member

I would support dropping anything that isn't called by the new functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants