fix: avoid scrolling up after show/hide permissions

intershop · Dec 22, 2023 · 6263074 · 6263074
1 parent 5828513
commit 6263074
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/...on-management/src/app/components/user-roles-selection/user-roles-selection.component.html b/...on-management/src/app/components/user-roles-selection/user-roles-selection.component.html
@@ -25,11 +25,11 @@
             </ul>
             <p>
               <!-- Expand/Collapse user permissions -->
-              <a *ngIf="!isExpanded[i]" [routerLink]="[]" (click)="toggleExpanded(i)">
+              <a *ngIf="!isExpanded[i]" (click)="toggleExpanded(i)" (keydown.enter)="toggleExpanded(i)" tabindex="0">
                 {{ 'account.user.details.profile.role.show_permissions.link' | translate }}&nbsp;
                 <fa-icon [icon]="['fas', 'angle-down']" />
               </a>
-              <a *ngIf="isExpanded[i]" [routerLink]="[]" (click)="toggleExpanded(i)">
+              <a *ngIf="isExpanded[i]" (click)="toggleExpanded(i)" (keydown.enter)="toggleExpanded(i)" tabindex="0">
                 {{ 'account.user.details.profile.role.hide_permissions.link' | translate }}&nbsp;
                 <fa-icon [icon]="['fas', 'angle-up']" />
               </a>

diff --git a/...management/src/app/components/user-roles-selection/user-roles-selection.component.spec.ts b/...management/src/app/components/user-roles-selection/user-roles-selection.component.spec.ts
@@ -1,6 +1,5 @@
 import { ComponentFixture, TestBed } from '@angular/core/testing';
 import { ReactiveFormsModule } from '@angular/forms';
-import { RouterTestingModule } from '@angular/router/testing';
 import { FaIconComponent } from '@fortawesome/angular-fontawesome';
 import { TranslateModule } from '@ngx-translate/core';
 import { MockComponent } from 'ng-mocks';
@@ -41,7 +40,7 @@ describe('User Roles Selection Component', () => {
     when(organizationManagementFacade.role$(approverRole.id)).thenReturn(of(approverRole));
 
     await TestBed.configureTestingModule({
-      imports: [ReactiveFormsModule, RouterTestingModule, TranslateModule.forRoot()],
+      imports: [ReactiveFormsModule, TranslateModule.forRoot()],
       declarations: [MockComponent(FaIconComponent), UserRolesSelectionComponent],
       providers: [{ provide: OrganizationManagementFacade, useFactory: () => instance(organizationManagementFacade) }],
     }).compileComponents();