Skip to content

Commit

Permalink
fix: revert selector-not-notation behavior to overload Bootstrap stan…
Browse files Browse the repository at this point in the history
…dard styles (#1218)

* the latest stylelint-config-standard update introduced the selector-not-notation rule with an incompatible standard configuration
* used the selector-not-notation with 'simple' option to keep previous ':not' notation style
  • Loading branch information
shauke authored Jul 20, 2022
1 parent 3979af0 commit 6bf7e47
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 4 deletions.
1 change: 1 addition & 0 deletions .stylelintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
"no-duplicate-selectors": true,
"property-no-vendor-prefix": true,
"selector-no-vendor-prefix": true,
"selector-not-notation": "simple",
"selector-pseudo-element-no-unknown": [
true,
{ "ignorePseudoElements": ["ng-deep"] }
Expand Down
2 changes: 1 addition & 1 deletion src/styles/components/footer/footer.scss
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ footer {

li {
a,
a:not([href], [tabindex]) {
a:not([href]):not([tabindex]) {
font-family: $font-family-condensedregular;
color: $text-color-quaternary;
text-decoration: none;
Expand Down
4 changes: 2 additions & 2 deletions src/styles/global/global.scss
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,11 @@ h4,
}

a,
a:not([href], [tabindex]) {
a:not([href]):not([tabindex]) {
color: $CORPORATE-PRIMARY;
}

a:not([href], [tabindex]) {
a:not([href]):not([tabindex]) {
&:hover {
color: $CORPORATE-SECONDARY;
}
Expand Down
2 changes: 1 addition & 1 deletion src/styles/pages/category/filter-row.scss
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@
padding-right: $space-default;

a,
a:not([href], [tabindex]) {
a:not([href]):not([tabindex]) {
color: $text-color-primary;
white-space: nowrap;

Expand Down

0 comments on commit 6bf7e47

Please sign in to comment.