Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

translations for common.button.navbarCollapsed.text missing in PWA #660

Closed
dhhyi opened this issue Apr 18, 2021 · 0 comments · Fixed by #666
Closed

translations for common.button.navbarCollapsed.text missing in PWA #660

dhhyi opened this issue Apr 18, 2021 · 0 comments · Fixed by #666
Assignees
@suschneider
Labels
bug Something isn't working
Milestone
0.30

Comments

@dhhyi
Copy link
Collaborator

dhhyi commented Apr 18, 2021

Actual Behavior

Translations key common.button.navbarCollapsed.text is used in PWA but not provided in translation files:

intershop-pwa/src/app/shell/header/header-default/header-default.component.html

Line 86 in 0d1be10

<span class="sr-only">{{ 'common.button.navbarCollapsed.text' | translate }}</span>

Expected Behavior

Translations for this key are available.

Additional Context, like Screenshots, Log File Snippets etc.

Found while working on #659
@dhhyi dhhyi added the bug Something isn't working label Apr 18, 2021
@SGrueber SGrueber self-assigned this Apr 20, 2021
@suschneider suschneider assigned suschneider and unassigned SGrueber Apr 20, 2021
@suschneider suschneider added this to the 0.30 milestone Apr 20, 2021
@suschneider suschneider mentioned this issue Apr 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@suschneider suschneider

Labels
bug Something isn't working
Projects
None yet
Milestone
0.30
Development

Successfully merging a pull request may close this issue.

fix: add missing text for navigation toggle intershop/intershop-pwa
3 participants
@dhhyi @SGrueber @suschneider