Provide a Callback for terminal.execute Function

[nikitaeverywhere]

This issue is a result of the discussion with @wcjphoenix #106.

It would be nice to have an optional callback in terminal.execute API function, execute(command, options, callback). The callback will receive the output after command execution is done. Example:

window.onTerminalInit((terminal) => {
    terminal.execute("write $namespace", (outputChunks) => { // by default, execute does not echo output onto the user's screen
        const result = outputChunks.join("");
        if (result !== "USER") {
            terminal.print("\r\n\nPlease, change your namespace to "USER" by executing \x1b[31mzn "USER"\x1b[0m\r\n");
        }
    });
});

[nikitaeverywhere]

Done by 19dea61.

[wcjphoenix]

Fantastic, thanks!

[nikitaeverywhere]

Please let me know if it works as expected! :)

[wcjphoenix]

It works well as long as there is not an Error in the code that is being executed. However when there is an error, it overrides the echo=false, and prints to terminal then reprompts the user which triggers the OnOutput function which runs the execute and then causes the error to happen again causing an infinite loop. Is there a reason that errors need to be echoed all the time and if so is it possible to have an option to turn that off?

Thanks,
Walter Jaskowiak

[nikitaeverywhere]

Oh yes, I need to fix this. Expect this fix to come tomorrow! Until then, I hope the error you are getting is not a big problem. Have a good weekend! Nikita

…

On Fri, Jul 7, 2017 at 6:45 PM wcjphoenix ***@***.***> wrote: It works well as long as there is not an Error in the code that is being executed. However when there is an error, it overrides the echo=false, and prints to terminal then reprompts the user which triggers the OnOutput function which runs the execute and then causes the error to happen again causing an infinite loop. Is there a reason that errors need to be echoed all the time and if so is it possible to have an option to turn that off? Thanks, Walter Jaskowiak — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <https://github.com/intersystems-ru/webterminal/issues/107#issuecomment-313718674>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEwhSLvOR6K_J-eKYAvMtVxN1K3ZoUTZks5sLlKWgaJpZM4OQCwm> .

[wcjphoenix]

Not at all, I just threw a try catch block around it.

Have a nice weekend!

[nikitaeverywhere]

I've fixed the error by c914b9f (v4.6.1). Now the error message should go to the outputChunks array.