Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git diff-based loading should do the right thing with detected renames #389

Closed
isc-tleavitt opened this issue Jun 28, 2024 · 1 comment · Fixed by #390
Closed

Git diff-based loading should do the right thing with detected renames #389

isc-tleavitt opened this issue Jun 28, 2024 · 1 comment · Fixed by #390
Assignees
Labels
bug Something isn't working

Comments

@isc-tleavitt
Copy link
Collaborator

Git diff might detect renames. These look like (e.g., from https://stackoverflow.com/questions/40702017/what-does-the-number-in-rnumber-after-a-git-rename-mean):

R079 Web/Views/Shared/Blocks/ChristmasLotteryBlock.cshtml Web/Views/Shared/Blocks/ChristmasLotteryBlock/Index.cshtml
R076 Web/Static/blocks/_block_christmas-lottery-intro.html Web/Views/Shared/Blocks/ChristmasLotteryBlock/_intro.cshtml
R099 Web/Static/blocks/_block_christmas-lottery-popup.html Web/Views/Shared/Blocks/ChristmasLotteryBlock/_popup.cshtml
M Web/Web.csproj

For purposes of IRIS, the file on the left is a delete and the file on the right is an add. Right now our diff-based incremental load tries to act on the file on the left, which doesn't exist, which can lead to very odd inexplicable failures after e.g. changing branches from the WebUI.

@isc-tleavitt
Copy link
Collaborator Author

Easy way to get here is by adding two routers to a production in two different branches, each with an empty routing rule

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant